Add tests

Author: nselvidge

src/eval.rs

@@ -4527,6 +4527,46 @@ mod tests {
         eval: EvalArgs,
     }
 
+    fn base_args() -> BaseArgs {
+        BaseArgs {
+            json: false,
+            quiet: false,
+            no_color: false,
+            profile: None,
+            org_name: None,
+            project: None,
+            api_key: None,
+            prefer_profile: false,
+            no_input: false,
+            api_url: None,
+            app_url: None,
+            env_file: None,
+        }
+    }
+
+    fn make_eval_args(files: Vec<String>) -> EvalArgs {
+        EvalArgs {
+            files,
+            runner: None,
+            language: None,
+            sandbox: EvalSandbox::Local,
+            no_send_logs: false,
+            jsonl: false,
+            terminate_on_failure: false,
+            num_workers: None,
+            list: false,
+            filter: Vec::new(),
+            verbose: false,
+            watch: false,
+            extra_args: Vec::new(),
+            dev: false,
+            dev_host: "localhost".to_string(),
+            dev_port: 8300,
+            dev_org_name: None,
+            dev_allowed_origin: Vec::new(),
+        }
+    }
+
     fn env_test_lock() -> &'static Mutex<()> {
         static LOCK: OnceLock<Mutex<()>> = OnceLock::new();
         LOCK.get_or_init(|| Mutex::new(()))
@@ -4616,6 +4656,12 @@ mod tests {
         }
     }
 
+    fn write_eval_file(dir: &Path, name: &str) -> String {
+        let path = dir.join(name);
+        fs::write(&path, "export {};").expect("eval file should be written");
+        path.to_string_lossy().to_string()
+    }
+
     #[test]
     fn join_app_url_normalizes_slashes() {
         let joined =
@@ -5787,6 +5833,105 @@ mod tests {
         }
     }
 
+    #[test]
+    fn eval_args_parse_sandbox_flag() {
+        let parsed =
+            EvalArgsHarness::try_parse_from(["bt", "--sandbox", "lambda", "sample.eval.ts"])
+                .expect("sandbox flag should parse");
+        assert_eq!(parsed.eval.sandbox, EvalSandbox::Lambda);
+        assert_eq!(parsed.eval.files, vec!["sample.eval.ts".to_string()]);
+    }
+
+    #[tokio::test]
+    async fn sandbox_eval_rejects_dev_mode() {
+        let dir = make_temp_dir("sandbox-dev");
+        let file = write_eval_file(&dir, "sample.eval.ts");
+        let mut args = make_eval_args(vec![file]);
+        args.sandbox = EvalSandbox::Lambda;
+        args.dev = true;
+
+        let err = run(base_args(), args)
+            .await
+            .expect_err("sandbox+dev should fail");
+        assert!(err
+            .to_string()
+            .contains("--sandbox is not supported with --dev."));
+
+        let _ = fs::remove_dir_all(&dir);
+    }
+
+    #[tokio::test]
+    async fn sandbox_eval_rejects_watch_mode() {
+        let dir = make_temp_dir("sandbox-watch");
+        let file = write_eval_file(&dir, "sample.eval.ts");
+        let mut args = make_eval_args(vec![file]);
+        args.sandbox = EvalSandbox::Lambda;
+        args.watch = true;
+
+        let err = run(base_args(), args)
+            .await
+            .expect_err("sandbox+watch should fail");
+        assert!(err
+            .to_string()
+            .contains("--sandbox is not supported with --watch."));
+
+        let _ = fs::remove_dir_all(&dir);
+    }
+
+    #[tokio::test]
+    async fn sandbox_eval_rejects_list_mode() {
+        let dir = make_temp_dir("sandbox-list");
+        let file = write_eval_file(&dir, "sample.eval.ts");
+        let mut args = make_eval_args(vec![file]);
+        args.sandbox = EvalSandbox::Lambda;
+        args.list = true;
+
+        let err = run(base_args(), args)
+            .await
+            .expect_err("sandbox+list should fail");
+        assert!(err
+            .to_string()
+            .contains("--sandbox is not supported with --list."));
+
+        let _ = fs::remove_dir_all(&dir);
+    }
+
+    #[tokio::test]
+    async fn sandbox_eval_rejects_no_send_logs() {
+        let dir = make_temp_dir("sandbox-local");
+        let file = write_eval_file(&dir, "sample.eval.ts");
+        let mut args = make_eval_args(vec![file]);
+        args.sandbox = EvalSandbox::Lambda;
+        args.no_send_logs = true;
+
+        let err = run(base_args(), args)
+            .await
+            .expect_err("sandbox+no-send-logs should fail");
+        assert!(err
+            .to_string()
+            .contains("--sandbox lambda is not supported with --no-send-logs."));
+
+        let _ = fs::remove_dir_all(&dir);
+    }
+
+    #[tokio::test]
+    async fn sandbox_eval_rejects_multiple_files() {
+        let dir = make_temp_dir("sandbox-multi");
+        let first = write_eval_file(&dir, "first.eval.ts");
+        let second = write_eval_file(&dir, "second.eval.ts");
+        let mut args = make_eval_args(vec![first, second]);
+        args.sandbox = EvalSandbox::Lambda;
+
+        let err = run(base_args(), args)
+            .await
+            .expect_err("sandbox+multiple files should fail");
+        assert!(err
+            .to_string()
+            .contains("`bt eval --sandbox lambda` currently supports exactly one eval file."));
+
+        let _ = fs::remove_dir_all(&dir);
+    }
+
     #[test]
     fn build_sandbox_summary_query_includes_timestamp_filter() {
         let query = build_sandbox_summary_query("exp'123", "2026-03-19T12:00:00.000Z");

src/functions/push.rs

@@ -737,9 +737,8 @@ pub(crate) async fn publish_eval_sandbox_functions(
         );
     }
 
-    let mut manifest =
-        run_functions_runner(&args, &files, language, auth_ctx.client.api_key())
-            .map_err(|failure| anyhow!(failure.message))?;
+    let mut manifest = run_functions_runner(&args, &files, language, auth_ctx.client.api_key())
+        .map_err(|failure| anyhow!(failure.message))?;
 
     for file in &mut manifest.files {
         file.entries.retain(|entry| match entry {
@@ -755,13 +754,8 @@ pub(crate) async fn publish_eval_sandbox_functions(
         bail!("no sandbox evaluators found in {}", source_file.display());
     }
 
-    validate_manifest_paths(
-        &manifest,
-        &files,
-        language,
-        &classified.allowed_roots,
-    )
-    .map_err(|failure| anyhow!(failure.message))?;
+    validate_manifest_paths(&manifest, &files, language, &classified.allowed_roots)
+        .map_err(|failure| anyhow!(failure.message))?;
 
     let preflight = collect_project_preflight(base, &manifest)?;
     let mut project_name_cache =