Skip to content

rm CATCHUP_ETL_ARN#229

Open
Hurshal Patel (choochootrain) wants to merge 2 commits intomainfrom
rm-catchup-etl
Open

rm CATCHUP_ETL_ARN#229
Hurshal Patel (choochootrain) wants to merge 2 commits intomainfrom
rm-catchup-etl

Conversation

@choochootrain
Copy link
Copy Markdown
Contributor

do not merge until confirmed

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a8038784f9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".

Comment on lines 52 to 55
AI_PROXY_FN_ARN = aws_lambda_function.ai_proxy.arn
AI_PROXY_FN_URL = aws_lambda_function_url.ai_proxy.function_url
AI_PROXY_INVOKE_ROLE = aws_iam_role.ai_proxy_invoke_role.arn
CATCHUP_ETL_ARN = aws_lambda_function.catchup_etl.arn
INSERT_LOGS2 = "true"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore CatchupETL ARN in API handler env

This change removes CATCHUP_ETL_ARN from the API handler’s default environment, which is the only in-module wiring from APIHandler to the Catchup ETL Lambda. The API handler role still includes a dedicated CatchupETLInvoke permission (modules/services/iam.tf lines 35-38), so the runtime path is still expected to invoke that function; without this env var, deployments using that path can fail at runtime unless operators manually re-add it via extra_env_vars.APIHandler.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants