Add IAM policy to allow Brainstore to assume export roles with bt:* ExternalId#242
Open
Jeff McCollum (jeffmccollum) wants to merge 4 commits intomainfrom
Open
Conversation
Jeff McCollum (jeffmccollum)
requested review from
Kevin Green (KevinGreen),
Hurshal Patel (choochootrain) and
Mike Deeks (mdeeks)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62d3072eac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Co-authored-by: Kevin Green <kevin.green@braintrust.dev>
Kevin Green (KevinGreen)
previously approved these changes
May 7, 2026
Kevin Green (KevinGreen)
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
bt:to support cross-account export workflows.Description
aws_iam_role_policy.brainstore_export_assume_rolewhich allowssts:AssumeRoleon all resources with aStringLikeconditionsts:ExternalId = "bt:*".aws_iam_role.brainstore_rolealongside existing S3, SecretsManager, and CloudWatch policies.Testing