Enable ASG metrics collection#273
Open
Mike Deeks (mdeeks) wants to merge 4 commits into
Open
Conversation
Co-authored-by: Mike Deeks <mdeeks@users.noreply.github.com>
Co-authored-by: Mike Deeks <mdeeks@users.noreply.github.com>
Co-authored-by: Mike Deeks <mdeeks@users.noreply.github.com>
Mike Deeks (mdeeks)
requested review from
brianvans (brianvans) and
Jeff McCollum (jeffmccollum)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2eb0b0a3a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Jeff McCollum (jeffmccollum)
previously approved these changes
Jun 24, 2026
Co-authored-by: Mike Deeks <mdeeks@users.noreply.github.com>
Kevin Green (KevinGreen)
approved these changes
Jul 2, 2026
brianvans (brianvans)
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable CloudWatch Auto Scaling group metrics collection for all Brainstore EC2 Auto Scaling Groups:
Each ASG now sets
metrics_granularity = "1Minute"and enables all metrics.Context
Brainstore runs on EC2 Auto Scaling Groups, but group-level ASG metrics were not enabled in the module. Enabling these metrics improves visibility into desired/in-service/pending/terminating capacity and instance counts.
Testing
PATH="/tmp/terraform-bin:$PATH" terraform fmt -check -diff modules/brainstore-ec2/main.tf modules/brainstore-ec2/main-writer.tf modules/brainstore-ec2/main-fast-reader.tfPATH="/tmp/terraform-bin:$PATH" terraform init -upgrade && PATH="/tmp/terraform-bin:$PATH" terraform validatecd examples/braintrust-data-planewith temporary local-modulemain_override.tf, thenPATH="/tmp/terraform-bin:$PATH" terraform init -upgrade && PATH="/tmp/terraform-bin:$PATH" terraform validate