chore: align JDK support and fix Error Prone compilation on JDK 11/17

- Set fail-fast: false in GitHub Actions.
- Use conditional Error Prone versions based on build JDK (2.31.0 for 11+, 2.42.0 for 17+, 2.48.0 for 21+).
- Add -XDaddTypeAnnotationsToSymbol=true for JDK 21+.
- Move maven-compiler-plugin config to pluginManagement for better merging.
- Update version in README.md to match pom.xml.

Author: bramp

.github/workflows/test.yml

@@ -16,6 +16,7 @@ jobs:
     # https://github.com/federicocarboni/setup-ffmpeg/issues/19
     environment: debug
     strategy:
+      fail-fast: false
       matrix:
         # Long term supported versions
         java-version: [11, 17, 21]

README.md

@@ -22,7 +22,7 @@ We currently support Java 11 and above. Use Maven to install the dependency.
 <dependency>
   <groupId>net.bramp.ffmpeg</groupId>
   <artifactId>ffmpeg</artifactId>
-  <version>0.8.0</version>
+  <version>0.8.1-SNAPSHOT</version>
 </dependency>
 ```
 

pom.xml

@@ -45,6 +45,8 @@
 
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+
+        <error.prone.version>2.31.0</error.prone.version>
     </properties>
 
     <dependencyManagement>
@@ -257,6 +259,19 @@
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-compiler-plugin</artifactId>
                     <version>3.15.0</version>
+                    <configuration>
+                        <source>${base.java.version}</source>
+                        <target>${base.java.version}</target>
+                        <showWarnings>true</showWarnings>
+                        <failOnError>true</failOnError>
+                        <failOnWarning>true</failOnWarning>
+                        <compilerArgs>
+                            <!-- Surpress maven option warnings because we are
+                            focusing on code issues -->
+                            <arg>-Xlint:-options</arg>
+                            <arg>-Xlint:all</arg>
+                        </compilerArgs>
+                    </configuration>
                 </plugin>
                 <plugin>
                     <groupId>net.revelc.code</groupId>
@@ -319,19 +334,6 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <configuration>
-                    <source>${base.java.version}</source>
-                    <target>${base.java.version}</target>
-                    <showWarnings>true</showWarnings>
-                    <failOnError>true</failOnError>
-                    <failOnWarning>true</failOnWarning>
-                    <compilerArgs>
-                        <!-- Surpress maven option warnings because we are
-                        focusing on code issues -->
-                        <arg>-Xlint:-options</arg>
-                        <arg>-Xlint:all</arg>
-                    </compilerArgs>
-                </configuration>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
@@ -754,7 +756,7 @@
                                     <path>
                                         <groupId>com.google.errorprone</groupId>
                                         <artifactId>error_prone_core</artifactId>
-                                        <version>2.48.0</version>
+                                        <version>${error.prone.version}</version>
                                     </path>
                                     <!-- Other annotation processors go here.
 
@@ -815,5 +817,41 @@
                 </pluginManagement>
             </build>
         </profile>
+
+        <profile>
+            <id>Java 17+</id>
+            <activation>
+                <jdk>[17,)</jdk>
+            </activation>
+            <properties>
+                <error.prone.version>2.42.0</error.prone.version>
+            </properties>
+        </profile>
+
+        <profile>
+            <id>Java 21+</id>
+            <activation>
+                <jdk>[21,)</jdk>
+            </activation>
+            <properties>
+                <error.prone.version>2.48.0</error.prone.version>
+            </properties>
+            <build>
+                <pluginManagement>
+                    <plugins>
+                        <plugin>
+                            <groupId>org.apache.maven.plugins</groupId>
+                            <artifactId>maven-compiler-plugin</artifactId>
+                            <configuration>
+                                <compilerArgs combine.children="append">
+                                    <!-- Flag needed for JDK 21+ Error Prone -->
+                                    <arg>-XDaddTypeAnnotationsToSymbol=true</arg>
+                                </compilerArgs>
+                            </configuration>
+                        </plugin>
+                    </plugins>
+                </pluginManagement>
+            </build>
+        </profile>
     </profiles>
 </project>