reduce usage of Nette Utils + integration test for Strings util

Author: passchn

src/Model/Entity/Asset.php

@@ -11,7 +11,6 @@
 use Cake\ORM\Entity;
 use Cake\Routing\Router;
 use League\Csv\Reader;
-use Nette\Utils\Arrays;
 use Nette\Utils\FileSystem;
 use Nette\Utils\Strings;
 
@@ -125,14 +124,22 @@ public function isViewableInBrowser(): bool
             return false;
         }
 
-        return Arrays::contains([
-                'image',
-                'video',
-            ], Strings::before((string)$this->mimetype, '/'))
-            || Arrays::contains([
-                'pdf',
-                'json',
-            ], Strings::after((string)$this->mimetype, '/'));
+        return in_array(
+            Strings::before((string)$this->mimetype, '/'),
+            [
+                    'image',
+                    'video',
+                ],
+            true
+        ) ||
+            in_array(
+                Strings::after((string)$this->mimetype, '/'),
+                [
+                    'pdf',
+                    'json',
+                ],
+                true
+            );
     }
 
     /**
@@ -144,7 +151,7 @@ public function isImage(): bool
     {
         return $this->exists()
             && Strings::before($this->mimetype ?? '', '/') === 'image'
-            && !Strings::contains((string)Strings::after($this->mimetype ?? '', '/'), 'svg');
+            && !str_contains((string)Strings::after($this->mimetype ?? '', '/'), 'svg');
     }
 
     /**

src/Utilities/ImageAsset.php

@@ -433,7 +433,7 @@ private function applyModifications(Image $image, ImageManager $manager): Image
         unset($modifications['noApi']);
 
         foreach ($modifications as $method => $params) {
-            if (Strings::contains($method, 'filter_')) {
+            if (str_contains($method, 'filter_')) {
                 $filterClassName = Strings::after($method, 'filter_') ?? '';
                 if (!class_exists($filterClassName)) {
                     throw new FilterNotFoundException("Filter {$filterClassName} does not exist. ");

tests/integration/Nette/StringsTest.php

@@ -0,0 +1,32 @@
+<?php
+declare(strict_types=1);
+
+namespace Assets\Test\integration\Nette;
+
+use Cake\TestSuite\TestCase;
+use Nette\Utils\Strings;
+
+class StringsTest extends TestCase
+{
+    public function testStrings(): void
+    {
+        $string = 'some_string-with/random7stuff.here';
+
+        $some_string = Strings::before($string, '-');
+        static::assertEquals('some_string', $some_string);
+
+        $here = Strings::after($string, '.', -1);
+        static::assertEquals('here', $here);
+
+        $random = Strings::before(Strings::after($string, '/'), '7');
+        static::assertEquals('random', $random);
+
+        $some_string = Strings::substring($string, 0, 11);
+        static::assertEquals('some_string', $some_string);
+        $ome_str = Strings::substring($string, 1, 7);
+        static::assertEquals('ome_str', $ome_str);
+
+        $someDotDotDot = Strings::truncate($string, 5);
+        static::assertEquals("some\u{2026}", $someDotDotDot);
+    }
+}