test: update tests

Author: brandonbothell

test/comments.spec.ts

@@ -29,9 +29,12 @@ describe('Comments', () => {
       .to.equal('The video identified by the <code><a href="/youtube/v3/docs/commentThreads/list#videoId">videoId</a></code> parameter has disabled comments.')
   })
 
-  it('should not work with invalid videos', async () => {
-    expect(await youtube.getVideoComments('JSFSFDKFaVeryFakeVideoID').catch(error => error.message))
-      .to.equal('The video identified by the <code><a href="/youtube/v3/docs/commentThreads/list#videoId">videoId</a></code> parameter could not be found.')
+  it('should work when searching comments by video title', async () => {
+    const comments = await youtube.getVideoComments('never gonna give you up')
+
+    expect(comments.items).to.be.an.instanceOf(Array)
+    expect(comments.items[0]).to.be.an.instanceOf(Comment)
+    expect(comments.nextPageToken).to.be.a('string')
   })
 
   it('should return an array with a length of <= maxPerPage', async () => {

test/playlist-items.spec.ts

@@ -12,9 +12,9 @@ if (!apiKey) {
 let playlist: Playlist
 
 describe('Playlist items', () => {
-  it('should reject if the playlist isn\'t found', async () => {
+  it('should reject if the playlist ID is invalid', async () => {
     expect(await youtube.getPlaylistItems('DSFDKLSDFaVeryFakePlaylistID')
-      .catch(error => error.message)).to.equal('The playlist identified with the request\'s <code>playlistId</code> parameter cannot be found.')
+      .catch(error => error.message)).to.equal('Invalid Value')
   })
 
   it('should reject if maxPerPage is > 50', async () => {

test/request.spec.ts

@@ -12,7 +12,7 @@ if (!apiKey) {
 }
 
 const request = new Request('https://www.googleapis.com/youtube/v3/', { apiKey })
-const testRequest = new Request('https://apichallenges.herokuapp.com/mirror/request/')
+const testRequest = new Request('https://httpbin.org/anything')
 
 describe('Requests', () => {
   it('should work consistently', async () => {
@@ -33,22 +33,31 @@ describe('Requests', () => {
 
   it('should work with multipart requests', async () => {
     const testData = JSON.stringify({ testKey: 'testValue' })
-    const result: string = await testRequest.multipartStreamPost('', {
+    const result: {
+      args: any
+      data: string
+      files: any
+      form: { [key: number]: string }
+      headers: { [key: string]: string }
+      json: any
+      method: 'GET' | 'POST' | 'PUT' | 'DELETE' | 'PATCH'
+      origin: string
+      url: string
+    } = await testRequest.multipartStreamPost('', {
       parts: [{
         data: testData
       }, {
         data: readFileSync(path.join(process.cwd(), 'package.json'))
       }],
       accept: 'application/json'
-    }).then(result => result.messageDetails)
-
-    expect(result.startsWith('POST https://apichallenges.herokuapp.com/mirror/request/')).to.equal(true)
-    expect(result).to.include('Content-Type: multipart/form-data; boundary=--------------------------')
-    expect(result).to.include(`Content-Disposition: form-data; name="0"\nContent-Type: application/json\n\n${testData}`)
-    expect(result).to.include(`Content-Disposition: form-data; name="1"\nContent-Type: application/octet-stream\n\n${
-      readFileSync(path.join(process.cwd(), 'package.json'), { encoding: 'utf8' })
-    }`)
-    expect(result.endsWith('--\n')).to.equal(true)
+    })
+
+    expect(result.url).to.equal('https://httpbin.org/anything')
+    expect(result.method).to.equal('POST')
+    expect(result.url).to.equal('https://httpbin.org/anything')
+    expect(result.headers['Content-Type']).to.include('multipart/form-data; boundary=--------------------------')
+    expect(JSON.stringify(result.form[0])).to.equal(JSON.stringify(testData))
+    expect(result.form[1]).to.equal(readFileSync(path.join(process.cwd(), 'package.json'), { encoding: 'utf8' }))
   })
 
   it('should throw errors', async () => {

test/search.spec.ts

@@ -55,7 +55,7 @@ describe('Searching', () => {
   it('should set what it can with search results', async () => {
     const channel = defaultChannelsSearch.items[0]
 
-    expect(channel.id).to.equal('UCuAXFkgsw1L7xaCfnd5JJOw')
+    expect(channel.id).to.equal('UCwZEU0wAwIyZb4x5G_KJp2w')
     expect(channel.country).to.equal(undefined)
     expect(channel.language).to.equal(undefined)
     expect(channel.views).to.equal(undefined)

test/subscription.spec.ts

@@ -17,15 +17,17 @@ describe('Subscriptions', () => {
 
     expect(testSubscription.id).to.be.a('string')
     expect(testSubscription.subscriber.id).to.equal(subscriber?.id)
-    expect(testSubscription.activities).to.satisfy(a => a === 'all' || a === 'uploads')
-    expect(testSubscription.channel).to.satisfy(c => typeof c.id === 'string' && typeof c.name === 'string')
+    expect(testSubscription.activities).to.satisfy((a: typeof Subscription.prototype.activities) => a === 'all' || a === 'uploads')
+    expect(testSubscription.channel).to.satisfy((c: typeof Subscription.prototype.channel) => typeof c.id === 'string' && typeof c.name === 'string')
     expect(testSubscription.dateSubscribed).to.be.an.instanceOf(Date)
     expect(testSubscription.description).to.be.a('string')
     expect(testSubscription.full).to.equal(true)
-    expect(testSubscription.items).to.satisfy(i => typeof i.new === 'number' && typeof i.total === 'number')
-    expect(testSubscription.subscriber)
-      .to.satisfy(s => typeof s.id === 'string' && typeof s.name === 'string' && typeof s.description === 'string' && typeof s.thumbnails === 'object')
-    expect(testSubscription.thumbnails).to.satisfy(t => typeof t.default === 'object' && typeof t.medium === 'object' && typeof t.high === 'object')
+    expect(testSubscription.items).to.satisfy((i: typeof Subscription.prototype.items) => typeof i.new === 'number' && typeof i.total === 'number')
+
+    expect(testSubscription.subscriber).to.satisfy((s: typeof Subscription.prototype.subscriber) =>
+      typeof s.id === 'string' && typeof s.name === 'string' && typeof s.description === 'string' && typeof s.thumbnails === 'object')
+    expect(testSubscription.thumbnails).to.satisfy((t: typeof Subscription.prototype.thumbnails) =>
+      typeof t.default === 'object' && typeof t.medium === 'object' && typeof t.high === 'object')
     expect(testSubscription.title).to.be.a('string')
   })
 
@@ -34,7 +36,7 @@ describe('Subscriptions', () => {
 
     try {
       new Subscription(youtube, { kind: 'invalid' })
-    } catch (err) {
+    } catch (err: any) {
       error = err.message
     }
 

test/youtube.spec.ts

@@ -3,7 +3,7 @@ import { Request } from '../src/util'
 import YouTube from '../src'
 import { expect } from 'chai'
 
-const testRequest = new Request('https://apichallenges.herokuapp.com/mirror/request/')
+const testRequest = new Request('https://httpbin.org/anything')
 
 describe('YouTube instance', () => {
   it('should set authorization', async () => {
@@ -15,14 +15,14 @@ describe('YouTube instance', () => {
       accept: 'application/json'
     })
 
-    expect(response.messageDetails.includes('Authorization: Bearer Another API key\n'))
+    expect(response.headers['Authorization']).to.equal('Bearer Another API key')
 
     youtube.setAuthorization({ apiKey: 'Fakest API Key Ever' })
     response = await youtube._request.get('', {
       authorizationOptions: { apiKey: true },
       accept: 'application/json'
     })
 
-    expect(response.messageDetails.includes('key: Fakest API Key Ever\n'))
+    expect(response.args['key']).to.equal('Fakest API Key Ever')
   })
 })