updating type hint for solutions#9

Open

tnguyen306 wants to merge 6 commits into

mainfrom

tnguyen306 commented Feb 9, 2023

Collaborator

@branhoff review please


          updating type hint for solution

5b0134f

tnguyen306 requested a review from branhoff

February 9, 2023 04:49

branhoff commented Feb 9, 2023

Owner

Quick note, can you add common virtual environment names to the .gitignore? I see the venv got committed. Same with the .DS_Store. That should be added to the .gitignore as well.

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/03b-project/find_factors.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/06c-project/std_dev.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/06c-project/std_dev.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/06c-project/std_dev.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/06c-project/std_dev.py Outdated


          not sure how the env files came in

0820f9c

branhoff commented Feb 9, 2023

Owner

The .DS_Store. still needs to be removed and then ignored for the future.

branhoff commented Feb 9, 2023

Owner

I pointed out a few, but type hints are missing for many of the variables and nearly all of the parameters in the parameter list.


          completed type hinting

1e2ab5b

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/04a-project/distance_fallen.py Outdated

-                  g = 9.8 # velocity
-                  return 0.5 * g * t*t
+              def fall_distance(t) -> float:

branhoff Feb 10, 2023

Owner

missing type hint on parameter t

branhoff Feb 16, 2023

Owner

still missing type hint on parameter t

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/04b-project/fibonacci.py Outdated

-                  curr_num = 1
-                  sol = 1
-                  for i in range(n-1):
+              def fib(n) -> int:

branhoff Feb 10, 2023

Owner

missing type hint on parameter n

branhoff Feb 16, 2023

Owner

still missing type hint on parameter n

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/04c-project/hailstone_step.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/05b-project/Taxicab.py Outdated

                   Represents a taxicab that tracks the distance traveled when given x and y coordinates
                   """
-                  def __init__(self, x, y):
+                  def __init__(self, x, y) -> None:

branhoff Feb 10, 2023

Owner

missing type hint on x and y parameters

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/06a-project/find_median.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/06a-project/find_median.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/06a-project/find_median.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/06b-project/add_surname.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/06b-project/add_surname.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/06c-project/std_dev.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/06c-project/std_dev.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/07a-project/square_list.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/07b-project/reverse_list.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/07b-project/reverse_list.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/08a-project/count_letters.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/08a-project/count_letters.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/08b-project/words_in_both.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/08b-project/words_in_both.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/08b-project/words_in_both.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/08c-project/make_employee_dict.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/08c-project/make_employee_dict.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/09-project/AddThreeGame.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/09-project/AddThreeGame.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/09-project/AddThreeGame.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/10-project/BuildersGame.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/10-project/BuildersGame.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/10-project/BuildersGame.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/10-project/BuildersGame.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/10-project/BuildersGame.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/10-project/BuildersGame.py Outdated

branhoff reviewed

View reviewed changes

branhoff left a comment

Owner

You may want to use mypy: https://www.mypy-lang.org/ to check that your type hinting is correct.

Thomas Nguyen added 2 commits

February 10, 2023 23:48


          more type hinting

01bda5a


          more type hint change

1b88493

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/03a-project/min_max_number.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/04b-project/fibonacci.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/04a-project/distance_fallen.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/07b-project/reverse_list.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/07b-project/reverse_list.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/07b-project/reverse_list.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/10-project/BuildersGame.py Outdated

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/10-project/BuildersGame.py

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/07b-project/reverse_list.py Outdated

               # Description: Mutates a given list and by the order of the elements of teh list
-              def reverse_list(lst):
+              def reverse_list(lst: any) -> None:

branhoff Feb 16, 2023

Owner

I don't believe any is a type hint. The recommendation I ready is to call object for the Any class. This should be type hinted as list[object]


          Resolved comments

b8f715e

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/07b-project/reverse_list.py

               # Description: Mutates a given list and by the order of the elements of teh list
-              def reverse_list(lst):
+              def reverse_list(lst: object) -> None:

branhoff Mar 2, 2023

Owner

this is type hinting a parameter named lst of any type. I think you mean lst: list[object]

branhoff reviewed

View reviewed changes

02-IDE_exercises/solutions/07b-project/reverse_list.py

                   """
-                  temp_lst = []
-                  for i in range(len(lst)-1,-1, -1):
+                  temp_lst: object = []

branhoff Mar 2, 2023

Owner

Same here. This should be temp_list: list[object] = []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet