Added on_death callback#99
Open
kylerippey wants to merge 3 commits into
Open
Conversation
|
@nglx Can you take a look at this? Would love to get this merged in, it just bit us. |
Author
|
For what it's worth, I've been running this fork in production for over a month now and it's been working pretty well. I'm very open to any feedback and suggestions that could help get it merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a swing at adding the
on_deathcallback. I haven't actually used this functionality in Sidekiq Pro, but I tried to implement the behavior exactly how the documents describe it. This callback should happen only once when the first job in the batch fully dies (exhausts all retries). It will not get called for every job in the batch that dies.I've been running this branch in production since yesterday and seeing it behave the way I expect. Please let me know if you want me to adjust implementation, add more specs, etc!
Thank you!
Resolves #51