download: send Last-Modified based on the served revision#12
Merged
Conversation
The tip-based last_modified middleware set Last-Modified on every response to the branch tip's commit time, which is wrong for downloads of files/tarballs from older revisions. Emit the header from the download handlers using the served revision's timestamp, and let the middleware skip responses that already carry one. Fixes: https://bugs.launchpad.net/loggerhead/+bug/503144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tip-based last_modified middleware set Last-Modified on every response to the branch tip's commit time, which is wrong for downloads of files/tarballs from older revisions. Emit the header from the download handlers using the served revision's timestamp, and let the middleware skip responses that already carry one.
Fixes: https://bugs.launchpad.net/loggerhead/+bug/503144