revision: wrap long commit-message strings so they don't overflow#14
Merged
Conversation
The commit-message block sits inside a 493px floated column, with the files-changed list floated next to it. `white-space: pre-wrap` alone only wraps on whitespace, so a long URL or other unbreakable string in the message spilled over and obscured the adjacent files list. Add `overflow-wrap: anywhere` + `word-break: break-word` on `.information` so the message stays inside its column. Also lift the `.information` styling out of the inline `style=` attribute in revision.html into diff.css. Fixes: https://bugs.launchpad.net/loggerhead/+bug/449980
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit-message block sits inside a 493px floated column, with the files-changed list floated next to it.
white-space: pre-wrapalone only wraps on whitespace, so a long URL or other unbreakable string in the message spilled over and obscured the adjacent files list. Addoverflow-wrap: anywhere+word-break: break-wordon.informationso the message stays inside its column.Also lift the
.informationstyling out of the inlinestyle=attribute in revision.html into diff.css.Fixes: https://bugs.launchpad.net/loggerhead/+bug/449980