Use method_exists for Symfony Console command registration shim.

Replace InstalledVersions version check with method_exists and configure PHPStan to ignore the unavoidable alreadyNarrowedType error on newer Symfony stubs.

Author: mnapoli

phpstan.neon

@@ -6,10 +6,9 @@ parameters:
     # Level 9 is the highest level
     level: 9
 
-#    ignoreErrors:
-#        - '#PHPDoc tag @var#'
-#
-#    excludePaths:
-#        - ./*/*/FileToBeExcluded.php
-#
-#    checkMissingIterableValueType: false
+    reportUnmatchedIgnoredErrors: false
+
+    ignoreErrors:
+        -
+            identifier: function.alreadyNarrowedType
+            path: src/Application.php

src/Application.php

@@ -5,7 +5,6 @@
 use Aws\Exception\CredentialsException;
 use Bref\Cli\Cli\IO;
 use Bref\Cli\Cli\Styles;
-use Composer\InstalledVersions;
 use ErrorException;
 use Exception;
 use Symfony\Component\Console\Command\Command;
@@ -39,27 +38,14 @@ public function __construct()
     public function safeAddCommand(Command $command): ?Command
     {
         // addCommand() exists since Symfony Console 7.4; add() was removed in Symfony 8.
-        $usesAddCommand = self::usesAddCommand();
-
-        $method = $usesAddCommand ? 'addCommand' : 'add';
+        $method = method_exists(parent::class, 'addCommand') ? 'addCommand' : 'add';
 
         /** @var callable(Command): ?Command $register */
         $register = [$this, $method];
 
         return $register($command);
     }
 
-    private static function usesAddCommand(): bool
-    {
-        if (! class_exists(InstalledVersions::class) || ! InstalledVersions::isInstalled('symfony/console')) {
-            throw new Exception('symfony/console is not installed');
-        }
-
-        $version = InstalledVersions::getVersion('symfony/console');
-
-        return $version !== null && version_compare($version, '7.4.0', '>=');
-    }
-
     public function doRun(InputInterface $input, OutputInterface $output): int
     {
         IO::init($input, $output);