Skip to content

Commit 2954f8e

Browse files
committed
Prevent decoders.status() function from adding None attributes to Status object.
1 parent a378bdd commit 2954f8e

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

obd/decoders.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,18 +299,24 @@ def status(messages):
299299

300300
# load the 3 base tests that are always present
301301
for i, name in enumerate(BASE_TESTS[::-1]):
302+
if name is None:
303+
continue # filter out None/reserved tests
302304
t = StatusTest(name, bits[13 + i], not bits[9 + i])
303305
output.__dict__[name] = t
304306

305307
# different tests for different ignition types
306308
if bits[12]: # compression
307309
for i, name in enumerate(COMPRESSION_TESTS[::-1]): # reverse to correct for bit vs. indexing order
310+
if name is None:
311+
continue # filter out None/reserved tests
308312
t = StatusTest(name, bits[(2 * 8) + i],
309313
not bits[(3 * 8) + i])
310314
output.__dict__[name] = t
311315

312316
else: # spark
313317
for i, name in enumerate(SPARK_TESTS[::-1]): # reverse to correct for bit vs. indexing order
318+
if name is None:
319+
continue # filter out None/reserved tests
314320
t = StatusTest(name, bits[(2 * 8) + i],
315321
not bits[(3 * 8) + i])
316322
output.__dict__[name] = t

0 commit comments

Comments
 (0)