Require JAX 0.6+ for import compatibility#56
Open
talolard wants to merge 1 commit into
Open
Conversation
Current main no longer uses the legacy typed.py path that referenced jax.core.JaxprEqn, but the package metadata still allowed older pre-0.6 JAX installs. Raise the JAX and jaxlib floors to the version where moved internals live under jax.extend.core and add a subprocess import regression test for issue brentyi#55.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #55 for the current
mainpackage line by aligning package metadata with the JAX API era that no longer exposes internals throughjax.core.Current
mainno longer contains the legacyjaxls/typed.pycode path that referencedjax.core.JaxprEqn; a fresh import succeeds with JAX 0.6+. This PR makes that compatibility explicit by:jax>=0.6.0andjaxlib>=0.6.0Validation
make formatfails before running becauseMakefilereferences an undefinedexamplesextra:error: Extra examples is not defined in the project's optional-dependencies tableuvx ruff format .uvx ruff check .uv run --python 3.12 --with-editable . --with 'jax==0.6.0' --with 'jaxlib==0.6.0' python - <<'PY' ... import jax; import jaxls ... PYuv run --python 3.12 --extra dev --extra cholmod pytestuv run --python 3.12 --extra dev --extra docs --extra cholmod pyright .uv run --python 3.12 --extra dev python transpile_py310.py && git diff --quiet src/jaxls/_py310/uvx ruff check . && uvx ruff format --check .for py in 3.10 3.11 3.12 3.13; do uv run --python "$py" --extra dev --extra cholmod pytest || exit $?; doneNote: local
cholmodvalidation required installing the same system dependency used by CI:libsuitesparse-dev.