Replaced php-http/message-factory with nyholm/psr7#44
Closed
evertharmeling wants to merge 1 commit into
Closed
Conversation
Owner
|
Thank you for yout contribution and the PR. It's an important task and should be done 👍 But currently I am struggling with the decision to require nyholm instead of psr/http-*
And f.e. nyholm as a suggested implementation. You mentioned an increased effort to implement it like that, do you think you can (like to) do it? |
Author
|
Thanks for the feedback, I was thinking the exact same thing, but I didn't want to impact the code too much yet. I'll dig into it a bit more. |
Author
|
Refactor was pretty simple :), see #45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
Package php-http/message-factory is abandoned, you should avoid using it. Use psr/http-factory instead.message.Directly switching to
psr/http-factory, results in quite some tests to be refactored, as the (deprecated)\Http\Message\MessageFactorywas an interface for multiple interfaces. By using thenyholm/psr7, we can use the\Nyholm\Psr7\Factory\Psr17Factoryas a direct drop-in replacement.Probably this means a bump to a new major version to remain backwards compatible as users could be using the
\Http\Message\MessageFactorydirectly?Otherwise the upgrade path is as simple as the changes in this PR:
php-http/message-factorynyholm/psr7Http\Message\MessageFactorywithNyholm\Psr7\Factory\Psr17FactoryI hope I don't miss something obvious, as it's almost to good to be true to still have all tests pass.
When approved/merged I'll take a look at updating the
ivory-google-map-bundletoo.