Skip to content

New password hashing scheme: PBKDF2#2

Open
SCG82 wants to merge 2 commits into
brettz9:eslintfrom
SCG82:brettz9-eslint-20190915
Open

New password hashing scheme: PBKDF2#2
SCG82 wants to merge 2 commits into
brettz9:eslintfrom
SCG82:brettz9-eslint-20190915

Conversation

@SCG82

@SCG82 SCG82 commented Sep 15, 2019

Copy link
Copy Markdown

Fully backwards compatible. New user passwords will be hashed using PBKDF2 (10000 iterations, sha256, 16 byte salt) and stored in MongoDB (hash length 32) along with a pass_ver field (pass_ver = 1). Users with no pass_ver field (or pass_ver: 0) will be validated using MD5.

brettz9 and others added 2 commits September 15, 2019 19:58
… instead)

- Breaking enhancement: Allow app to pass in own countries list
- Breaking refactoring: `EmailDispatcher` and `AccountManager` are now classes; routes accepts config
- Update: Use now required Mongodb APIs
- Linting (ESLint): Apply eslint-config-ash-nazg
- Refactoring: Destructuring; arrow functions for handlers; utilize succincter stylus features
- npm: Update deps and devDeps; put deps, devDeps together
- npm: Remove redundant `private: false`
@brettz9 brettz9 force-pushed the eslint branch 6 times, most recently from 4a4bab4 to dbfe0ec Compare September 15, 2019 15:14
@ghost

ghost commented Nov 12, 2019

Copy link
Copy Markdown

I like this ! @brettz9

@brettz9

brettz9 commented Nov 12, 2019

Copy link
Copy Markdown
Owner

Oh, sorry, I hadn't noticed this PR for some reason. Yes, indeed, intend to include. Let me finish up my current branch work.

@ghost

ghost commented Nov 12, 2019

Copy link
Copy Markdown

Cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants