review feedback

Author: patelspratik

pkg/cmd/register/register_test.go

@@ -255,9 +255,9 @@ func Test_runRegister_UserCancels(t *testing.T) {
 	}
 
 	// Registration should not exist
-	exists, eerr := regStore.Exists()
-	if eerr != nil {
-		t.Fatalf("Exists error: %v", eerr)
+	exists, err := regStore.Exists()
+	if err != nil {
+		t.Fatalf("Exists error: %v", err)
 	}
 	if exists {
 		t.Error("registration should not exist after cancel")

pkg/cmd/upgrade/detector.go

@@ -7,9 +7,9 @@ type InstallMethod int
 
 const (
 	// InstallMethodDirect means brev was installed via direct binary download.
-	InstallMethodDirect InstallMethod = iota
+	InstallMethodDirect InstallMethod = 0
 	// InstallMethodBrew means brev was installed via Homebrew.
-	InstallMethodBrew
+	InstallMethodBrew InstallMethod = 1
 )
 
 // Detector determines how brev was installed.

pkg/cmd/upgrade/runner.go

@@ -4,12 +4,12 @@ import (
 	"fmt"
 	"os"
 	"os/exec"
-	"path/filepath"
-	"runtime"
 
 	"github.com/brevdev/brev-cli/pkg/terminal"
 )
 
+const installScriptURL = "https://raw.githubusercontent.com/brevdev/brev-cli/main/bin/install-latest.sh"
+
 // Upgrader executes the actual upgrade process.
 type Upgrader interface {
 	UpgradeViaBrew(t *terminal.Terminal) error
@@ -33,68 +33,16 @@ func (SystemUpgrader) UpgradeViaBrew(t *terminal.Terminal) error {
 	return nil
 }
 
-// UpgradeViaInstallScript downloads and installs the latest brev binary from GitHub.
+// UpgradeViaInstallScript runs the upstream install-latest.sh script via sudo.
 func (SystemUpgrader) UpgradeViaInstallScript(t *terminal.Terminal) error {
-	osName := runtime.GOOS
-	arch := runtime.GOARCH
-
-	t.Vprintf("Detected platform: %s/%s\n", osName, arch)
+	t.Vprintf("Running: bash -c \"$(curl -fsSL %s)\"\n", installScriptURL)
 	t.Vprint("")
 
-	// Fetch latest release download URL
-	t.Vprint("Fetching latest release...")
-	pattern := fmt.Sprintf("browser_download_url.*%s.*%s", osName, arch)
-	curlCmd := fmt.Sprintf(
-		`curl -s https://api.github.com/repos/brevdev/brev-cli/releases/latest | grep "%s" | cut -d '"' -f 4`,
-		pattern,
-	)
-	out, err := exec.Command("bash", "-c", curlCmd).Output() //nolint:gosec // constructing URL pattern from known values
-	if err != nil {
-		return fmt.Errorf("failed to fetch latest release: %w", err)
-	}
-	downloadURL := string(out)
-	if downloadURL == "" {
-		return fmt.Errorf("could not find release for %s/%s", osName, arch)
-	}
-	// Trim trailing newline
-	downloadURL = downloadURL[:len(downloadURL)-1]
-
-	// Create temp directory
-	tmpDir, err := os.MkdirTemp("", "brev-upgrade-*")
-	if err != nil {
-		return fmt.Errorf("failed to create temp directory: %w", err)
-	}
-	defer os.RemoveAll(tmpDir)
-
-	// Download
-	t.Vprintf("Downloading %s...\n", downloadURL)
-	tarPath := filepath.Join(tmpDir, "brev.tar.gz")
-	dlCmd := exec.Command("curl", "-sL", downloadURL, "-o", tarPath)
-	dlCmd.Stderr = os.Stderr
-	if err := dlCmd.Run(); err != nil {
-		return fmt.Errorf("download failed: %w", err)
-	}
-
-	// Extract
-	extractCmd := exec.Command("tar", "-xzf", tarPath, "-C", tmpDir)
-	if err := extractCmd.Run(); err != nil {
-		return fmt.Errorf("extraction failed: %w", err)
-	}
-
-	// Install with sudo
-	brevPath := filepath.Join(tmpDir, "brev")
-	t.Vprint("Installing to /usr/local/bin/brev...")
-	mvCmd := exec.Command("sudo", "mv", brevPath, "/usr/local/bin/brev")
-	mvCmd.Stdout = os.Stdout
-	mvCmd.Stderr = os.Stderr
-	if err := mvCmd.Run(); err != nil {
-		return fmt.Errorf("failed to install binary: %w", err)
-	}
-
-	chmodCmd := exec.Command("sudo", "chmod", "+x", "/usr/local/bin/brev")
-	if err := chmodCmd.Run(); err != nil {
-		return fmt.Errorf("failed to set permissions: %w", err)
+	cmd := exec.Command("bash", "-c", fmt.Sprintf(`curl -fsSL "%s" | bash`, installScriptURL)) //nolint:gosec // URL is a compile-time constant
+	cmd.Stdout = os.Stdout
+	cmd.Stderr = os.Stderr
+	if err := cmd.Run(); err != nil {
+		return fmt.Errorf("install script failed: %w", err)
 	}
-
 	return nil
 }

pkg/sudo/sudo.go

@@ -14,11 +14,11 @@ type Status int
 
 const (
 	// StatusRoot means the process is already running as root.
-	StatusRoot Status = iota
+	StatusRoot Status = 0
 	// StatusCached means the user has a valid sudo timestamp (no password needed).
-	StatusCached
+	StatusCached Status = 1
 	// StatusUncached means sudo will require a password prompt.
-	StatusUncached
+	StatusUncached Status = 2
 )
 
 // Check returns the current sudo status.