Skip to content

Commit 5ca40ae

Browse files
Fix errcheck and noctx
1 parent 9530c5a commit 5ca40ae

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

pkg/integration/cli_output_compatibility_test.go

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package integration
22

33
import (
4+
"context"
45
"encoding/json"
56
"net/http"
67
"net/http/httptest"
@@ -222,20 +223,29 @@ func Test_APIInstanceTypesEndpoint(t *testing.T) {
222223
}
223224

224225
w.Header().Set("Content-Type", "application/json")
225-
json.NewEncoder(w).Encode(response)
226+
err := json.NewEncoder(w).Encode(response)
227+
if err != nil {
228+
http.Error(w, "Failed to encode response", http.StatusInternalServerError)
229+
return
230+
}
226231
}))
227232
defer server.Close()
228233

229234
// Test the API endpoint
230235
client := &http.Client{Timeout: 5 * time.Second}
231-
req, err := http.NewRequest("GET", server.URL+"/v1/instance/types", nil)
236+
ctx := context.Background()
237+
req, err := http.NewRequestWithContext(ctx, "GET", server.URL+"/v1/instance/types", nil)
232238
require.NoError(t, err)
233239

234240
req.Header.Set("User-Agent", "nvidia-ai-workbench")
235241

236242
resp, err := client.Do(req)
237243
require.NoError(t, err)
238-
defer resp.Body.Close()
244+
defer func() {
245+
if closeErr := resp.Body.Close(); closeErr != nil {
246+
t.Logf("Failed to close response body: %v", closeErr)
247+
}
248+
}()
239249

240250
assert.Equal(t, 200, resp.StatusCode, "API should return 200 OK")
241251
assert.Equal(t, "application/json", resp.Header.Get("Content-Type"), "API should return JSON")

0 commit comments

Comments
 (0)