Skip to content

Commit b903bbf

Browse files
committed
fix: gracefully handle GitHub API failures in version check
Return current version instead of erroring when the GitHub releases API fails (e.g. rate limiting). This prevents the CLI from crashing when the API is unavailable.
1 parent 78b382a commit b903bbf

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

pkg/remoteversion/remoteversion.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import (
66
"github.com/fatih/color"
77

88
"github.com/brevdev/brev-cli/pkg/cmd/version"
9-
breverrors "github.com/brevdev/brev-cli/pkg/errors"
109
"github.com/brevdev/brev-cli/pkg/store"
1110
"github.com/brevdev/brev-cli/pkg/terminal"
1211
)
@@ -34,8 +33,7 @@ type VersionStore interface {
3433
func BuildVersionString(t *terminal.Terminal, versionStore VersionStore) (string, error) {
3534
githubRelease, err := versionStore.GetLatestReleaseMetadata()
3635
if err != nil {
37-
t.Errprint(err, "Failed to retrieve latest version")
38-
return "", breverrors.WrapAndTrace(err)
36+
return fmt.Sprintf(upToDateString, version.Version), nil
3937
}
4038

4139
var versionString string
@@ -57,8 +55,7 @@ func BuildVersionString(t *terminal.Terminal, versionStore VersionStore) (string
5755
func BuildCheckLatestVersionString(t *terminal.Terminal, versionStore VersionStore) (string, error) {
5856
githubRelease, err := versionStore.GetLatestReleaseMetadata()
5957
if err != nil {
60-
t.Errprint(err, "Failed to retrieve latest version")
61-
return "", breverrors.WrapAndTrace(err)
58+
return "", nil
6259
}
6360

6461
versionString := ""

0 commit comments

Comments
 (0)