feat: test-codecov-report

Author: kirtiip20

pkg/cmd/hello/hello_test.go

@@ -1 +1,19 @@
 package hello
+
+import "testing"
+
+func TestShellOnboardingPollDone(t *testing.T) {
+	t.Parallel()
+	if !shellOnboardingPollDone(&OnboardingObject{HasRunBrevShell: true}) {
+		t.Fatal("expected true when HasRunBrevShell is set")
+	}
+	if shellOnboardingPollDone(&OnboardingObject{HasRunBrevShell: false}) {
+		t.Fatal("expected false when HasRunBrevShell is false")
+	}
+	if shellOnboardingPollDone(&OnboardingObject{HasRunBrevOpen: true, HasRunBrevShell: false}) {
+		t.Fatal("HasRunBrevOpen alone must not end shell onboarding wait")
+	}
+	if shellOnboardingPollDone(nil) {
+		t.Fatal("expected false for nil res")
+	}
+}

pkg/cmd/hello/onboarding_utils.go

@@ -123,6 +123,10 @@ type OnboardingObject struct {
 	HasRunBrevOpen  bool `json:"hasRunBrevOpen"`
 }
 
+func shellOnboardingPollDone(res *OnboardingObject) bool {
+	return res != nil && res.HasRunBrevShell
+}
+
 func SetupDefaultOnboardingFile() error {
 	// get path
 	path, err := GetOnboardingFilePath()

pkg/cmd/hello/steps.go

@@ -242,7 +242,7 @@ func doBrevShellOnboarding(
 		if err1 != nil {
 			return breverrors.WrapAndTrace(err1)
 		}
-		if res.HasRunBrevOpen {
+		if shellOnboardingPollDone(res) {
 			spinner.Suffix = spinnerSuffix
 			time.Sleep(250 * time.Millisecond)
 			spinner.Stop()