fix: only pipe output to stdout on full success

Address drewmalin's review: don't send names to stdout when there are
partial failures, since the next piped command would act on them even
without pipefail. Also send admin delete message to stderr instead of
stdout, and remove unused ExitCodeError type.

Author: theFong

main.go

@@ -1,7 +1,6 @@
 package main
 
 import (
-	stderrors "errors"
 	"os"
 
 	"github.com/brevdev/brev-cli/pkg/cmd"
@@ -17,11 +16,6 @@ func main() {
 	if err := command.Execute(); err != nil {
 		cmderrors.DisplayAndHandleError(err)
 		done()
-		exitCode := 1
-		var exitErr errors.ExitCodeError
-		if stderrors.As(err, &exitErr) {
-			exitCode = exitErr.ExitCode
-		}
-		os.Exit(exitCode) //nolint:gocritic // manually call done
+		os.Exit(1) //nolint:gocritic // manually call done
 	}
 }

pkg/cmd/delete/delete.go

@@ -3,6 +3,7 @@ package delete
 import (
 	_ "embed"
 	"fmt"
+	"os"
 	"strings"
 
 	"github.com/brevdev/brev-cli/pkg/cmd/completions"
@@ -52,15 +53,15 @@ func NewCmdDelete(t *terminal.Terminal, loginDeleteStore DeleteStore, noLoginDel
 					deletedNames = append(deletedNames, workspace)
 				}
 			}
-			// Output names for piping to next command
+			if allError != nil {
+				return breverrors.WrapAndTrace(allError)
+			}
+			// Only output names for piping if all succeeded
 			if piped {
 				for _, name := range deletedNames {
 					fmt.Println(name)
 				}
 			}
-			if allError != nil {
-				return breverrors.WrapAndTrace(allError)
-			}
 			return nil
 		},
 	}
@@ -106,7 +107,7 @@ func handleAdminUser(err error, deleteStore DeleteStore, piped bool) error {
 			return breverrors.WrapAndTrace(err)
 		}
 		if !piped {
-			fmt.Println("attempting to delete an instance you don't own as admin")
+			fmt.Fprintln(os.Stderr, "attempting to delete an instance you don't own as admin")
 		}
 		return nil
 	}

pkg/cmd/start/start.go

@@ -701,19 +701,15 @@ func runBatchStart(t *terminal.Terminal, names []string, org, setupScript, setup
 			startedNames = append(startedNames, instanceName)
 		}
 	}
-	// Always output successful names for piping to next command
+	if errs != nil {
+		return breverrors.WrapAndTrace(errs)
+	}
+	// Only output names for piping if all succeeded
 	if piped {
 		for _, n := range startedNames {
 			fmt.Println(n)
 		}
 	}
-	if errs != nil {
-		exitCode := 1 // all failed
-		if len(startedNames) > 0 {
-			exitCode = 2 // partial failure
-		}
-		return breverrors.NewExitCodeError(errs, exitCode)
-	}
 	return nil
 }
 

pkg/cmd/stop/stop.go

@@ -61,19 +61,15 @@ func NewCmdStop(t *terminal.Terminal, loginStopStore StopStore, noLoginStopStore
 						stoppedNames = append(stoppedNames, name)
 					}
 				}
-				// Output names for piping to next command
+				if allErr != nil {
+					return breverrors.WrapAndTrace(allErr)
+				}
+				// Only output names for piping if all succeeded
 				if piped {
 					for _, name := range stoppedNames {
 						fmt.Println(name)
 					}
 				}
-				if allErr != nil {
-					exitCode := 1 // all failed
-					if len(stoppedNames) > 0 {
-						exitCode = 2 // partial failure
-					}
-					return breverrors.NewExitCodeError(allErr, exitCode)
-				}
 			}
 			return nil
 		},

pkg/errors/errors.go

@@ -123,27 +123,6 @@ func (v ValidationError) Error() string {
 	return v.Message
 }
 
-// ExitCodeError wraps an error with a specific process exit code.
-// Use this to distinguish between failure modes (e.g., partial vs full failure).
-type ExitCodeError struct {
-	Err      error
-	ExitCode int
-}
-
-func NewExitCodeError(err error, exitCode int) ExitCodeError {
-	return ExitCodeError{Err: err, ExitCode: exitCode}
-}
-
-var _ error = ExitCodeError{}
-
-func (e ExitCodeError) Error() string {
-	return e.Err.Error()
-}
-
-func (e ExitCodeError) Unwrap() error {
-	return e.Err
-}
-
 type DeclineToLoginError struct{}
 
 func (d *DeclineToLoginError) Error() string     { return "declined to login" }