fix error messages

Author: patelspratik

pkg/cmd/gpucreate/gpucreate.go

@@ -882,7 +882,11 @@ func (c *createContext) waitForInstances(workspaces []*entity.Workspace) {
 	for _, ws := range workspaces {
 		err := c.pollUntilReady(ws.ID)
 		if err != nil {
-			c.logf("  %s: Timeout waiting for ready state\n", ws.Name)
+			if strings.Contains(err.Error(), "timeout waiting") {
+				c.logf("  %s: Timeout waiting for ready state\n", ws.Name)
+			} else {
+				c.logf("  %s: %s\n", ws.Name, c.colorize(err.Error(), c.t.Red))
+			}
 		}
 	}
 }
@@ -1225,6 +1229,9 @@ func (c *createContext) pollUntilReady(wsID string) error {
 		}
 
 		if ws.Status == entity.Failure {
+			if ws.StatusMessage != "" {
+				return breverrors.NewValidationError(fmt.Sprintf("instance %s failed: %s", ws.Name, ws.StatusMessage))
+			}
 			return breverrors.NewValidationError(fmt.Sprintf("instance %s failed", ws.Name))
 		}
 

pkg/cmd/gpucreate/gpucreate_test.go

@@ -3,6 +3,7 @@ package gpucreate
 import (
 	"strings"
 	"testing"
+	"time"
 
 	"github.com/brevdev/brev-cli/pkg/cmd/gpusearch"
 	"github.com/brevdev/brev-cli/pkg/entity"
@@ -645,3 +646,22 @@ func TestFormatInstanceSpecs(t *testing.T) {
 	result := formatInstanceSpecs(specs)
 	assert.Equal(t, "g5.xlarge (1000GB disk), p4d.24xlarge, g6.xlarge (500GB disk)", result)
 }
+
+func TestPollUntilReadyReportsWorkspaceFailureMessage(t *testing.T) {
+	store := NewMockGPUCreateStore()
+	store.Workspaces["ws-failed"] = &entity.Workspace{
+		ID:            "ws-failed",
+		Name:          "test",
+		Status:        entity.Failure,
+		StatusMessage: "unexpected end of JSON input",
+	}
+
+	ctx := &createContext{
+		store: store,
+		opts:  GPUCreateOptions{Timeout: time.Second},
+	}
+
+	err := ctx.pollUntilReady("ws-failed")
+
+	assert.ErrorContains(t, err, "instance test failed: unexpected end of JSON input")
+}