add in brevd logic#273
Closed
patelspratik wants to merge 23 commits into
Closed
Conversation
mistercodedor
suggested changes
Jan 9, 2026
| return &Client{} | ||
| } | ||
|
|
||
| baseURL := config.GlobalConfig.GetDevplaneAPIURL() |
Contributor
There was a problem hiding this comment.
pass this in as an arg instead of having a dep on the global config?
| Labels map[string]string | ||
| } | ||
|
|
||
| func (c *Client) ListCloudCredID(ctx context.Context, orgID string) (string, error) { |
Contributor
There was a problem hiding this comment.
this signature is fine for now, but the longer term access model includes user private, cloud private, etc.
| } | ||
|
|
||
| func (c *Client) ListCloudCredID(ctx context.Context, orgID string) (string, error) { | ||
| resp, err := c.cloudCreds.ListCloudCred(ctx, connect.NewRequest(&devplaneapiv1.ListCloudCredRequest{ |
Contributor
There was a problem hiding this comment.
instead of exposing the inner label structure, should we add a operator API that returns the relevant CloudCreds for brevcloud?
Contributor
There was a problem hiding this comment.
since agent has been coopted by agentic AI we should use daemon or some other term that is not overloaded
|
|
||
| code, runErr := run(ctx) | ||
| if runErr != nil { | ||
| zap.L().Error("brev-agent exited with error", zap.Error(runErr)) |
| RegistrationToken: msg.GetRegistrationToken(), | ||
| } | ||
| if ts := msg.GetExpiresAt(); ts != nil { | ||
| out.ExpiresAt = ts.AsTime().UTC().Format(time.RFC3339) |
Contributor
There was a problem hiding this comment.
because the time format conversion is used across many places, let's normalize it into a helper so that it does not drift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.