fix: handle provider status default cases across providers

garvitssoni · garvitssoni · commit 283b69b4d0e3 · 2026-04-07T15:49:13.000+05:30
diff --git a/v1/providers/fluidstack/instance.go b/v1/providers/fluidstack/instance.go
@@ -131,7 +131,7 @@ func convertFluidStackInstanceToV1Instance(fsInstance openapi.Instance) *v1.Inst
 	case openapi.INSTANCE_ERROR:
 		lifecycleStatus = v1.LifecycleStatusFailed
 	default:
-		lifecycleStatus = v1.LifecycleStatusPending
+		lifecycleStatus = ""
 	}
 
 	instance := &v1.Instance{
diff --git a/v1/providers/lambdalabs/instance.go b/v1/providers/lambdalabs/instance.go
@@ -217,7 +217,7 @@ func convertLambdaLabsStatusToV1Status(status string) v1.LifecycleStatus {
 	case "unhealthy":
 		return v1.LifecycleStatusRunning
 	default:
-		return v1.LifecycleStatusPending
+		return ""
 	}
 }
 
diff --git a/v1/providers/nebius/instance.go b/v1/providers/nebius/instance.go
@@ -247,7 +247,7 @@ func (c *NebiusClient) convertNebiusInstanceToV1(ctx context.Context, instance *
 		case compute.InstanceStatus_ERROR:
 			lifecycleStatus = v1.LifecycleStatusFailed
 		default:
-			lifecycleStatus = v1.LifecycleStatusFailed
+			lifecycleStatus = ""
 		}
 	} else {
 		lifecycleStatus = v1.LifecycleStatusFailed
diff --git a/v1/providers/sfcompute/instance.go b/v1/providers/sfcompute/instance.go
@@ -415,7 +415,7 @@ func sfcStatusToLifecycleStatus(status string) v1.LifecycleStatus {
 	case "nodefailure", "failed":
 		return v1.LifecycleStatusFailed
 	default:
-		return v1.LifecycleStatusPending
+		return ""
 	}
 }
 
diff --git a/v1/providers/shadeform/instance.go b/v1/providers/shadeform/instance.go
@@ -291,7 +291,7 @@ func (c *ShadeformClient) getLifecycleStatus(status string) v1.LifecycleStatus {
 	case "error":
 		lifecycleStatus = v1.LifecycleStatusFailed
 	default:
-		lifecycleStatus = v1.LifecycleStatusPending
+		lifecycleStatus = ""
 	}
 	return lifecycleStatus
 }

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ func convertFluidStackInstanceToV1Instance(fsInstance openapi.Instance) *v1.Inst`
`131`	`131`	`case openapi.INSTANCE_ERROR:`
`132`	`132`	`lifecycleStatus = v1.LifecycleStatusFailed`
`133`	`133`	`default:`
`134`		`- lifecycleStatus = v1.LifecycleStatusPending`
	`134`	`+ lifecycleStatus = ""`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`instance := &v1.Instance{`
Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ func convertLambdaLabsStatusToV1Status(status string) v1.LifecycleStatus {`
`217`	`217`	`case "unhealthy":`
`218`	`218`	`return v1.LifecycleStatusRunning`
`219`	`219`	`default:`
`220`		`- return v1.LifecycleStatusPending`
	`220`	`+ return ""`
`221`	`221`	`}`
`222`	`222`	`}`
`223`	`223`
Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ func (c NebiusClient) convertNebiusInstanceToV1(ctx context.Context, instance `
`247`	`247`	`case compute.InstanceStatus_ERROR:`
`248`	`248`	`lifecycleStatus = v1.LifecycleStatusFailed`
`249`	`249`	`default:`
`250`		`- lifecycleStatus = v1.LifecycleStatusFailed`
	`250`	`+ lifecycleStatus = ""`
`251`	`251`	`}`
`252`	`252`	`} else {`
`253`	`253`	`lifecycleStatus = v1.LifecycleStatusFailed`
Original file line number	Diff line number	Diff line change
`@@ -415,7 +415,7 @@ func sfcStatusToLifecycleStatus(status string) v1.LifecycleStatus {`
`415`	`415`	`case "nodefailure", "failed":`
`416`	`416`	`return v1.LifecycleStatusFailed`
`417`	`417`	`default:`
`418`		`- return v1.LifecycleStatusPending`
	`418`	`+ return ""`
`419`	`419`	`}`
`420`	`420`	`}`
`421`	`421`
Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ func (c *ShadeformClient) getLifecycleStatus(status string) v1.LifecycleStatus {`
`291`	`291`	`case "error":`
`292`	`292`	`lifecycleStatus = v1.LifecycleStatusFailed`
`293`	`293`	`default:`
`294`		`- lifecycleStatus = v1.LifecycleStatusPending`
	`294`	`+ lifecycleStatus = ""`
`295`	`295`	`}`
`296`	`296`	`return lifecycleStatus`
`297`	`297`	`}`