fix: handle provider status default cases across providers

garvitssoni · garvitssoni · commit 37f6b33ca550 · 2026-04-07T17:08:40.000+05:30
diff --git a/v1/instance.go b/v1/instance.go
@@ -112,6 +112,7 @@ const (
 	LifecycleStatusTerminating LifecycleStatus = "terminating"
 	LifecycleStatusTerminated  LifecycleStatus = "terminated"
 	LifecycleStatusFailed      LifecycleStatus = "failed"
+	LifecycleStatusEmpty	   LifecycleStatus = ""
 )
 
 const (
diff --git a/v1/providers/lambdalabs/instance.go b/v1/providers/lambdalabs/instance.go
@@ -217,7 +217,7 @@ func convertLambdaLabsStatusToV1Status(status string) v1.LifecycleStatus {
 	case "unhealthy":
 		return v1.LifecycleStatusRunning
 	default:
-		return ""
+		return v1.LifecycleStatusEmpty
 	}
 }
 
diff --git a/v1/providers/nebius/instance.go b/v1/providers/nebius/instance.go
@@ -247,7 +247,7 @@ func (c *NebiusClient) convertNebiusInstanceToV1(ctx context.Context, instance *
 		case compute.InstanceStatus_ERROR:
 			lifecycleStatus = v1.LifecycleStatusFailed
 		default:
-			lifecycleStatus = ""
+			lifecycleStatus = v1.LifecycleStatusEmpty
 		}
 	} else {
 		lifecycleStatus = v1.LifecycleStatusFailed
diff --git a/v1/providers/sfcompute/instance.go b/v1/providers/sfcompute/instance.go
@@ -415,7 +415,7 @@ func sfcStatusToLifecycleStatus(status string) v1.LifecycleStatus {
 	case "nodefailure", "failed":
 		return v1.LifecycleStatusFailed
 	default:
-		return ""
+		return v1.LifecycleStatusEmpty
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,7 @@ const (`
`112`	`112`	`LifecycleStatusTerminating LifecycleStatus = "terminating"`
`113`	`113`	`LifecycleStatusTerminated LifecycleStatus = "terminated"`
`114`	`114`	`LifecycleStatusFailed LifecycleStatus = "failed"`
	`115`	`+ LifecycleStatusEmpty LifecycleStatus = ""`
`115`	`116`	`)`
`116`	`117`
`117`	`118`	`const (`
Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ func convertLambdaLabsStatusToV1Status(status string) v1.LifecycleStatus {`
`217`	`217`	`case "unhealthy":`
`218`	`218`	`return v1.LifecycleStatusRunning`
`219`	`219`	`default:`
`220`		`- return ""`
	`220`	`+ return v1.LifecycleStatusEmpty`
`221`	`221`	`}`
`222`	`222`	`}`
`223`	`223`
Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ func (c NebiusClient) convertNebiusInstanceToV1(ctx context.Context, instance `
`247`	`247`	`case compute.InstanceStatus_ERROR:`
`248`	`248`	`lifecycleStatus = v1.LifecycleStatusFailed`
`249`	`249`	`default:`
`250`		`- lifecycleStatus = ""`
	`250`	`+ lifecycleStatus = v1.LifecycleStatusEmpty`
`251`	`251`	`}`
`252`	`252`	`} else {`
`253`	`253`	`lifecycleStatus = v1.LifecycleStatusFailed`
Original file line number	Diff line number	Diff line change
`@@ -415,7 +415,7 @@ func sfcStatusToLifecycleStatus(status string) v1.LifecycleStatus {`
`415`	`415`	`case "nodefailure", "failed":`
`416`	`416`	`return v1.LifecycleStatusFailed`
`417`	`417`	`default:`
`418`		`- return ""`
	`418`	`+ return v1.LifecycleStatusEmpty`
`419`	`419`	`}`
`420`	`420`	`}`
`421`	`421`