fix: handle provider status default cases across providers

garvitssoni · garvitssoni · commit 464b0c3fdbca · 2026-04-10T13:40:33.000+05:30
diff --git a/v1/instance.go b/v1/instance.go
@@ -112,7 +112,7 @@ const (
 	LifecycleStatusTerminating LifecycleStatus = "terminating"
 	LifecycleStatusTerminated  LifecycleStatus = "terminated"
 	LifecycleStatusFailed      LifecycleStatus = "failed"
-	LifecycleStatusEmpty	   LifecycleStatus = ""
+	LifecycleStatusEmpty       LifecycleStatus = ""
 )
 
 const (
diff --git a/v1/providers/fluidstack/instance.go b/v1/providers/fluidstack/instance.go
@@ -131,7 +131,7 @@ func convertFluidStackInstanceToV1Instance(fsInstance openapi.Instance) *v1.Inst
 	case openapi.INSTANCE_ERROR:
 		lifecycleStatus = v1.LifecycleStatusFailed
 	default:
-		lifecycleStatus = ""
+		lifecycleStatus = v1.LifecycleStatusEmpty
 	}
 
 	instance := &v1.Instance{
diff --git a/v1/providers/shadeform/instance.go b/v1/providers/shadeform/instance.go
@@ -291,7 +291,7 @@ func (c *ShadeformClient) getLifecycleStatus(status string) v1.LifecycleStatus {
 	case "error":
 		lifecycleStatus = v1.LifecycleStatusFailed
 	default:
-		lifecycleStatus = ""
+		lifecycleStatus = v1.LifecycleStatusEmpty
 	}
 	return lifecycleStatus
 }

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ const (`
`112`	`112`	`LifecycleStatusTerminating LifecycleStatus = "terminating"`
`113`	`113`	`LifecycleStatusTerminated LifecycleStatus = "terminated"`
`114`	`114`	`LifecycleStatusFailed LifecycleStatus = "failed"`
`115`		`- LifecycleStatusEmpty LifecycleStatus = ""`
	`115`	`+ LifecycleStatusEmpty LifecycleStatus = ""`
`116`	`116`	`)`
`117`	`117`
`118`	`118`	`const (`
Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ func convertFluidStackInstanceToV1Instance(fsInstance openapi.Instance) *v1.Inst`
`131`	`131`	`case openapi.INSTANCE_ERROR:`
`132`	`132`	`lifecycleStatus = v1.LifecycleStatusFailed`
`133`	`133`	`default:`
`134`		`- lifecycleStatus = ""`
	`134`	`+ lifecycleStatus = v1.LifecycleStatusEmpty`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`instance := &v1.Instance{`
Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ func (c *ShadeformClient) getLifecycleStatus(status string) v1.LifecycleStatus {`
`291`	`291`	`case "error":`
`292`	`292`	`lifecycleStatus = v1.LifecycleStatusFailed`
`293`	`293`	`default:`
`294`		`- lifecycleStatus = ""`
	`294`	`+ lifecycleStatus = v1.LifecycleStatusEmpty`
`295`	`295`	`}`
`296`	`296`	`return lifecycleStatus`
`297`	`297`	`}`