feedback

Author: drewmalin

.github/workflows/validation-aws.yml

@@ -40,7 +40,7 @@ jobs:
             - name: Install dependencies
               run: make deps
 
-            - name: Run Nebius validation tests
+            - name: Run AWS validation tests
               env:
                   AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
                   AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}

.github/workflows/validation-nebius.yml

@@ -43,7 +43,7 @@ jobs:
             - name: Run Nebius validation tests
               env:
                   NEBIUS_PUBLIC_KEY_ID: ${{ secrets.NEBIUS_PUBLIC_KEY_ID }}
-                  NEBIUS_PRIVATE_KEY_PEM_BASE64: ${{ secrets.NEBIUS_SERVICE_ACCOUNT_ID }}
+                  NEBIUS_PRIVATE_KEY_PEM_BASE64: ${{ secrets.NEBIUS_PRIVATE_KEY_PEM_BASE64 }}
                   NEBIUS_SERVICE_ACCOUNT_ID: ${{ secrets.NEBIUS_SERVICE_ACCOUNT_ID }}
                   NEBIUS_PROJECT_ID: ${{ secrets.NEBIUS_PROJECT_ID }}
                   TEST_USER_PRIVATE_KEY_PEM_BASE64: ${{ secrets.TEST_USER_PRIVATE_KEY_PEM_BASE64 }}

internal/rsa/rsa.go

@@ -15,30 +15,33 @@ func BytesToRSAKey(keyBytes []byte) (any, error) {
 	// The key may be in OpenSSH format
 	key, err := ssh.ParseRawPrivateKey(keyBytes)
 	if err == nil {
-		// No error, so we can parse into a key object
+		// This is an OpenSSH key, now check to see if it is a private key
 		switch k := key.(type) {
 		case *rsa.PrivateKey, *ed25519.PrivateKey:
 			return k, nil
 		default:
+			// This is an OpenSSH key, but it is not a private key
 			return nil, fmt.Errorf("key is not an RSA private key")
 		}
 	}
 
 	// The key may be in PKCS8 format
 	key, err = x509.ParsePKCS8PrivateKey(keyBytes)
 	if err == nil {
-		// No error, so we can parse into a key object
+		// This is a PKCS8 key, now check to see if it is a private key
 		switch k := key.(type) {
 		case *rsa.PrivateKey, *ed25519.PrivateKey:
 			return k, nil
 		default:
+			// This is a PKCS8 key, but it is not a private key
 			return nil, fmt.Errorf("key is not an RSA private key")
 		}
 	}
 
 	// The key may be in PKCS1 format
 	key, err = x509.ParsePKCS1PrivateKey(keyBytes)
 	if err == nil {
+		// This is a PKCS1 private key, return it
 		return key, nil
 	}
 

v1/providers/aws/validation_network_test.go

@@ -11,8 +11,8 @@ import (
 
 var (
 	isValidationTest = os.Getenv("VALIDATION_TEST")
-	accessKeyID     = os.Getenv("AWS_ACCESS_KEY_ID")
-	secretAccessKey = os.Getenv("AWS_SECRET_ACCESS_KEY")
+	accessKeyID      = os.Getenv("AWS_ACCESS_KEY_ID")
+	secretAccessKey  = os.Getenv("AWS_SECRET_ACCESS_KEY")
 )
 
 func TestAWSNetworkValidation(t *testing.T) {