Skip to content

Commit 93f0792

Browse files
committed
feedback
1 parent 2888d27 commit 93f0792

2 files changed

Lines changed: 3 additions & 10 deletions

File tree

v1/providers/aws/scripts/network_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,6 @@ func TestCreateVPC(t *testing.T) {
4040
if err != nil {
4141
t.Fatalf("failed to get VPC: %v", err)
4242
}
43-
44-
// err = awsClient.DeleteVPC(context.Background(), v1.DeleteVPCArgs{
45-
// ID: vpc.ID,
46-
// })
47-
// if err != nil {
48-
// t.Fatalf("failed to delete VPC: %v", err)
49-
// }
5043
}
5144

5245
func TestDeleteVPC(t *testing.T) {

v1/vpc.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ import (
99

1010
// VPC represents the complete specification of a Brev VPC.
1111
type VPC struct {
12+
// The ID assigned by the cloud provider to the VPC.
13+
id CloudProviderResourceID
14+
1215
// The name of the VPC, displayed on clients.
1316
name string
1417

@@ -22,9 +25,6 @@ type VPC struct {
2225
// The cloud that hosts the VPC. For example, "aws".
2326
cloud string
2427

25-
// The ID assigned by the cloud provider to the VPC.
26-
id CloudProviderResourceID
27-
2828
// The location of the VPC. For example, "us-east-1".
2929
location string
3030

0 commit comments

Comments
 (0)