unit tests

Author: drewmalin

v1/providers/aws/kubernetes.go

@@ -24,6 +24,22 @@ import (
 	v1 "github.com/brevdev/cloud/v1"
 )
 
+var (
+	errUsernameIsRequired     = fmt.Errorf("username is required")
+	errRoleIsRequired         = fmt.Errorf("role is required")
+	errClusterIDIsRequired    = fmt.Errorf("cluster ID is required")
+	errRSAPEMBase64IsRequired = fmt.Errorf("RSA PEM base64 is required")
+
+	errNodeGroupMinNodeCountMustBeGreaterThan0                     = fmt.Errorf("node group minNodeCount must be greater than 0")
+	errNodeGroupMaxNodeCountMustBeGreaterThan0                     = fmt.Errorf("node group maxNodeCount must be greater than 0")
+	errNodeGroupMaxNodeCountMustBeGreaterThanOrEqualToMinNodeCount = fmt.Errorf("node group maxNodeCount must be greater than or equal to minNodeCount")
+	errNodeGroupInstanceTypeIsRequired                             = fmt.Errorf("node group instanceType is required")
+	errNodeGroupDiskSizeGiBMustBeGreaterThanOrEqualTo20            = fmt.Errorf("node group diskSizeGiB must be greater than or equal to 20")
+	errNodeGroupDiskSizeGiBMustBeLessThanOrEqualToMaxInt32         = fmt.Errorf("node group diskSizeGiB must be less than or equal to %d", math.MaxInt32)
+	errNodeGroupMaxNodeCountMustBeLessThanOrEqualToMaxInt32        = fmt.Errorf("node group maxNodeCount must be less than or equal to %d", math.MaxInt32)
+	errNodeGroupMinNodeCountMustBeLessThanOrEqualToMaxInt32        = fmt.Errorf("node group minNodeCount must be less than or equal to %d", math.MaxInt32)
+)
+
 var _ v1.CloudMaintainKubernetes = &AWSClient{}
 
 const iamRolePathPrefix = "/brevcloudsdk/eks/clusters"
@@ -484,28 +500,28 @@ func (c *AWSClient) CreateNodeGroup(ctx context.Context, args v1.CreateNodeGroup
 func validateCreateNodeGroupArgs(args v1.CreateNodeGroupArgs) error {
 	errs := []error{}
 	if args.MinNodeCount < 1 {
-		errs = append(errs, fmt.Errorf("node group minNodeCount must be greater than 0"))
+		errs = append(errs, errNodeGroupMinNodeCountMustBeGreaterThan0)
 	}
 	if args.MaxNodeCount < 1 {
-		errs = append(errs, fmt.Errorf("node group maxNodeCount must be greater than 0"))
+		errs = append(errs, errNodeGroupMaxNodeCountMustBeGreaterThan0)
 	}
 	if args.MaxNodeCount < args.MinNodeCount {
-		errs = append(errs, fmt.Errorf("node group maxNodeCount must be greater than or equal to minNodeCount"))
+		errs = append(errs, errNodeGroupMaxNodeCountMustBeGreaterThanOrEqualToMinNodeCount)
 	}
 	if args.InstanceType == "" {
-		errs = append(errs, fmt.Errorf("node group instanceType is required"))
+		errs = append(errs, errNodeGroupInstanceTypeIsRequired)
 	}
 	if args.DiskSizeGiB < 20 {
-		errs = append(errs, fmt.Errorf("node group diskSizeGiB must be greater than or equal to 20"))
+		errs = append(errs, errNodeGroupDiskSizeGiBMustBeGreaterThanOrEqualTo20)
 	}
 	if args.DiskSizeGiB > math.MaxInt32 {
-		errs = append(errs, fmt.Errorf("node group diskSizeGiB must be less than or equal to %d", math.MaxInt32))
+		errs = append(errs, errNodeGroupDiskSizeGiBMustBeLessThanOrEqualToMaxInt32)
 	}
 	if args.MaxNodeCount > math.MaxInt32 {
-		errs = append(errs, fmt.Errorf("node group maxNodeCount must be less than or equal to %d", math.MaxInt32))
+		errs = append(errs, errNodeGroupMaxNodeCountMustBeLessThanOrEqualToMaxInt32)
 	}
 	if args.MinNodeCount > math.MaxInt32 {
-		errs = append(errs, fmt.Errorf("node group minNodeCount must be less than or equal to %d", math.MaxInt32))
+		errs = append(errs, errNodeGroupMinNodeCountMustBeLessThanOrEqualToMaxInt32)
 	}
 	return errors.WrapAndTrace(errors.Join(errs...))
 }
@@ -638,19 +654,19 @@ func (c *AWSClient) ModifyNodeGroup(ctx context.Context, args v1.ModifyNodeGroup
 func validateModifyNodeGroupArgs(args v1.ModifyNodeGroupArgs) error {
 	errs := []error{}
 	if args.MinNodeCount < 1 {
-		errs = append(errs, fmt.Errorf("node group minNodeCount must be greater than 0"))
+		errs = append(errs, errNodeGroupMinNodeCountMustBeGreaterThan0)
 	}
 	if args.MaxNodeCount < 1 {
-		errs = append(errs, fmt.Errorf("node group maxNodeCount must be greater than 0"))
+		errs = append(errs, errNodeGroupMaxNodeCountMustBeGreaterThan0)
 	}
 	if args.MaxNodeCount < args.MinNodeCount {
-		errs = append(errs, fmt.Errorf("node group maxNodeCount must be greater than or equal to minNodeCount"))
+		errs = append(errs, errNodeGroupMaxNodeCountMustBeGreaterThanOrEqualToMinNodeCount)
 	}
 	if args.MinNodeCount > math.MaxInt32 {
-		errs = append(errs, fmt.Errorf("node group minNodeCount must be less than or equal to %d", math.MaxInt32))
+		errs = append(errs, errNodeGroupMinNodeCountMustBeLessThanOrEqualToMaxInt32)
 	}
 	if args.MaxNodeCount > math.MaxInt32 {
-		errs = append(errs, fmt.Errorf("node group maxNodeCount must be less than or equal to %d", math.MaxInt32))
+		errs = append(errs, errNodeGroupMaxNodeCountMustBeLessThanOrEqualToMaxInt32)
 	}
 	return errors.WrapAndTrace(errors.Join(errs...))
 }
@@ -816,16 +832,16 @@ func (c *AWSClient) SetClusterUser(ctx context.Context, args v1.SetClusterUserAr
 func validatePutUserArgs(args v1.SetClusterUserArgs) error {
 	errs := []error{}
 	if args.Username == "" {
-		errs = append(errs, fmt.Errorf("username is required"))
+		errs = append(errs, errUsernameIsRequired)
 	}
 	if args.Role == "" {
-		errs = append(errs, fmt.Errorf("role is required"))
+		errs = append(errs, errRoleIsRequired)
 	}
 	if args.ClusterID == "" {
-		errs = append(errs, fmt.Errorf("cluster ID is required"))
+		errs = append(errs, errClusterIDIsRequired)
 	}
 	if args.RSAPEMBase64 == "" {
-		errs = append(errs, fmt.Errorf("RSA PEM base64 is required"))
+		errs = append(errs, errRSAPEMBase64IsRequired)
 	}
 	return errors.WrapAndTrace(errors.Join(errs...))
 }