Skip to content

Commit 3ea6537

Browse files
authored
chore: upgrade devcontainer at node 22 and add python3 for pg-native (#3595)
* chore: upgrade devcontainer at node 22 and add python3 for pg-native * fix(test): in dev container must be use the env
1 parent f332f28 commit 3ea6537

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

.devcontainer/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
44
#-------------------------------------------------------------------------------------------------------------
55

6-
FROM node:20
6+
FROM node:22
77

88
# Avoid warnings by switching to noninteractive
99
ENV DEBIAN_FRONTEND=noninteractive
@@ -35,7 +35,7 @@ RUN apt-get update \
3535
&& echo "deb https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/ stable main" | tee /etc/apt/sources.list.d/yarn.list \
3636
&& apt-get update \
3737
&& apt-get -y install --no-install-recommends yarn tmux locales postgresql \
38-
&& apt-get install libpq-dev g++ make \
38+
&& apt-get install libpq-dev python3 g++ make \
3939
#
4040
# Install eslint globally
4141
&& npm install -g eslint \

.devcontainer/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ services:
3939
- db:db
4040

4141
db:
42-
image: postgres:14-alpine
42+
image: postgres:14
4343
restart: unless-stopped
4444
ports:
4545
- 5432:5432

packages/pg-native/test/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ describe('connection', function () {
77
})
88

99
it('connects with args', function (done) {
10-
Client().connect('host=localhost', done)
10+
Client().connect(`host=${process.env.PGHOST || 'localhost'}`, done)
1111
})
1212

1313
it('errors out with bad connection args', function (done) {

0 commit comments

Comments
 (0)