fix(exports): resolve issues with module imports and requires#3428
Merged
brianc merged 2 commits intobrianc:masterfrom Apr 23, 2025
Merged
fix(exports): resolve issues with module imports and requires#3428brianc merged 2 commits intobrianc:masterfrom
brianc merged 2 commits intobrianc:masterfrom
Conversation
This was referenced Apr 23, 2025
Owner
|
doh! First of all, thanks for the quick work here. Secondly....dang I feel bad sending a breaking change! That was pretty unexpected...I'll get this released asap. |
brianc
added a commit
that referenced
this pull request
Apr 23, 2025
brianc
added a commit
that referenced
this pull request
Apr 23, 2025
|
@brianc New Relic Node Agent team here. Thanks for getting this merged! We're still seeing errors, though. |
Owner
ohhhh okay i see it now. OMG Sorry there's so much breakage. I'll add those now w/ some tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a regression introduced in
pg@8.15.1due to the addition of ESM support via #3423. The updatedexportsfield inpackage.jsonrestricts access to internal modules such aslib/connection-parameters.js, which are utilized by tools like node-pg-migrateAs a result, users such as salsita/node-pg-migrate#1398, #3429, #3431, possibly #3430 (couldn't replicate) encounter the following or similar errors:
To resolve this, I've updated the
exportsfield to include./lib/*, ensuring compatibility with existing tools that rely on them.