From bc0b88e26836c0d319bb1b836a61b434e84b298c Mon Sep 17 00:00:00 2001 From: Noritaka Kobayashi Date: Mon, 26 May 2025 10:38:46 +0900 Subject: [PATCH] refactor: use for...of for better readability --- packages/pg-cursor/index.js | 3 +-- packages/pg/lib/utils.js | 3 +-- packages/pg/test/cli.js | 4 ++-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/pg-cursor/index.js b/packages/pg-cursor/index.js index f1553cc9c..a1b24e1f7 100644 --- a/packages/pg-cursor/index.js +++ b/packages/pg-cursor/index.js @@ -174,8 +174,7 @@ class Cursor extends EventEmitter { this._cb(msg) } // dispatch error to all waiting callbacks - for (let i = 0; i < this._queue.length; i++) { - const queuedCallback = this._queue[i][1] + for (const [_, queuedCallback] of this._queue) { queuedCallback.call(this, msg) } this._queue.length = 0 diff --git a/packages/pg/lib/utils.js b/packages/pg/lib/utils.js index e91794ba0..9b6bda48f 100644 --- a/packages/pg/lib/utils.js +++ b/packages/pg/lib/utils.js @@ -173,8 +173,7 @@ const escapeLiteral = function (str) { let hasBackslash = false let escaped = "'" - for (let i = 0; i < str.length; i++) { - const c = str[i] + for (const c of str) { if (c === "'") { escaped += c + c } else if (c === '\\') { diff --git a/packages/pg/test/cli.js b/packages/pg/test/cli.js index 5bea4912c..e4df023f2 100644 --- a/packages/pg/test/cli.js +++ b/packages/pg/test/cli.js @@ -2,8 +2,8 @@ const ConnectionParameters = require('../lib/connection-parameters') const config = new ConnectionParameters(process.argv[2]) -for (let i = 0; i < process.argv.length; i++) { - switch (process.argv[i].toLowerCase()) { +for (const arg of process.argv) { + switch (arg.toLowerCase()) { case 'native': config.native = true break