Add Security Best Practices guide to documentation#3575
Closed
ofri-peretz wants to merge 1 commit intobrianc:masterfrom
Closed
Add Security Best Practices guide to documentation#3575ofri-peretz wants to merge 1 commit intobrianc:masterfrom
ofri-peretz wants to merge 1 commit intobrianc:masterfrom
Conversation
Author
|
Hi @charmander why closing the PR? Did I do something wrong? |
Collaborator
|
low-quality, AI-generated, and basically spam despite the disclosure |
Author
|
Can you guide me through what should I do? @charmander ? What is the missing quality, I would like to learn and provide a better one. |
Collaborator
|
No, I’m not going to spend that kind of disproportionate effort on this. |
Repository owner
locked as spam and limited conversation to collaborators
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a comprehensive Security Best Practices guide to the node-postgres documentation, covering common security pitfalls and how to prevent them.
Contributing Guidelines Compliance
Per the README Contributing section:
What's Added
New file:
docs/pages/guides/security.mdTopics Covered:
Each section includes:
Static Analysis Tools Section
The guide also recommends eslint-plugin-pg as a static analysis tool to catch these issues at development time.
Disclosure: I am the author of eslint-plugin-pg. The recommendation is disclosed transparently and the tool is genuinely useful for node-postgres users.
Why This Matters
Security is not currently covered in the node-postgres documentation. This guide helps developers avoid common mistakes that lead to:
Preview
The guide follows the existing documentation style and integrates with the current navigation structure.