Fix test assertions for TLS-enabled mariadb-connector-c connections#1432
Open
FaramosCZ wants to merge 1 commit into
Open
Fix test assertions for TLS-enabled mariadb-connector-c connections#1432FaramosCZ wants to merge 1 commit into
FaramosCZ wants to merge 1 commit into
Conversation
mariadb-connector-c 3.4.0+ enables MYSQL_OPT_SSL_VERIFY_SERVER_CERT by default (MDEV-31857), so all TCP connections use TLS. This changes the error messages surfaced when connections are disrupted: - fork() corrupts shared TLS state, raising "TLS/SSL error" in both child and parent instead of silent success - Connection kills and timeouts surface as TLS errors rather than "Lost connection to MySQL server" Adapt test expectations to accept both TLS and non-TLS error messages, so the test suite passes regardless of whether the connector library enforces TLS. Co-Authored-By: Claude AI <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mariadb-connector-c 3.4.0+ enables MYSQL_OPT_SSL_VERIFY_SERVER_CERT by default (MDEV-31857), so all TCP connections use TLS. This changes the error messages surfaced when connections are disrupted:
Adapt test expectations to accept both TLS and non-TLS error messages, so the test suite passes regardless of whether the connector library enforces TLS.