Move doctrine/orm to require-dev

[janedbal]

Hi, I used your repository to test our composer-dependency-analyser and I believe it found one issue:

• There is not a single usage of any symbol from doctrine/orm in src so I believe it should not be listed in require.
  • So I moved it to require-dev
• I also added this tool to CI so that such problem never happens again

[BenMorel]

Hi @janedbal!

This is a tough one. On one hand, your tool is right: we only implement stuff from DBAL. On the other hand, I remember having to raise the minimum Doctrine ORM version in 24adc1f.

Reason:

Fixes the following error with lowest dependencies:

"continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

I guess this is because of conflicting versions between:

• the lowest doctrine/orm versions compatible with the current version of date-time-doctrine
• the latest PHP versions compatible with the current version of date-time-doctrine

This may be an issue with Doctrine itself, that doesn't specify the maximum PHP version allowed (I'm guilty of that with Brick, too).

We do want to continue testing with lowest deps, so for now I guess it makes sense to require doctrine/orm just to specify the minimum compatible version. Also, this package probably makes little sense without the ORM anyway, so it probably doesn't hurt?

[janedbal]

This is totally up to you and understandable for such purpose.

I just checked your repo and it felt valid, but I do not have the context you have. Feel free to close this.

[janedbal]

So, close this or ignore doctrine/orm and keep the tool?