github: update actions and trigger builds on pull reqs

Author: johnl

.github/workflows/build-cloud-controller-manager.yaml

@@ -3,32 +3,32 @@ on:
   push:
     tags:
       - '*'
+
 jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - 
-        name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v2
-      - 
-        name: Set up Docker Metadata
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+      - name: Set up Docker Metadata
         id: meta
-        uses: docker/metadata-action@v4
+        uses: docker/metadata-action@v5
         with:
           images: |
             cr.brightbox.com/${{ vars.CR_ACCOUNT }}/${{ vars.CR_REPO }}/brightbox-cloud-controller-manager
           tags: |
             type=semver,pattern={{version}}
-      - 
-        name: Login to Brightbox Container Registry
-        uses: docker/login-action@v2
+            type=ref,event=pr
+      - name: Login to Brightbox Container Registry
+        uses: docker/login-action@v3
         with:
           registry: cr.brightbox.com
           username: ${{ vars.CR_USERNAME }}
           password: ${{ secrets.CR_SECRET }}
-      - 
-        name: Docker build and push
-        uses: docker/build-push-action@v4
+      - name: Docker build and push
+        uses: docker/build-push-action@v6
         with:
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}

.github/workflows/test-prs.yaml

@@ -1,15 +1,45 @@
-name: "Test Pull Requests"
+name: "Test And Build Pull Requests"
 
-on: 
+on:
   pull_request:
 
 jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-go@v4
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
         with:
           go-version-file: go.mod
+          cache: true
       - name: Test
-        uses: robherley/go-test-action@v0.1.0
+        uses: robherley/go-test-action@v0.7.1
+  build:
+    runs-on: ubuntu-latest
+    needs: test
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+      - name: Set up Docker Metadata
+        id: meta
+        uses: docker/metadata-action@v5
+        with:
+          images: |
+            cr.brightbox.com/${{ vars.CR_ACCOUNT }}/${{ vars.CR_REPO }}/brightbox-cloud-controller-manager
+          tags: |
+            type=ref,event=pr
+      - name: Login to Brightbox Container Registry
+        uses: docker/login-action@v3
+        with:
+          registry: cr.brightbox.com
+          username: ${{ vars.CR_USERNAME }}
+          password: ${{ secrets.CR_SECRET }}
+      - name: Docker build and push
+        uses: docker/build-push-action@v6
+        with:
+          tags: ${{ steps.meta.outputs.tags }}
+          labels: ${{ steps.meta.outputs.labels }}
+          push: true
+          cache-from: type=gha
+          cache-to: type=gha,mode=max