Upgrade biome 2.5.0#485
Open
jaudiger wants to merge 3 commits into
Open
Conversation
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the five directly-used biome_* crates from 0.5.7 to 2.5.0, pulling them from the
@biomejs/biome@2.5.0tag.The new version ships several breaking API changes that required code updates:
format_nodenow takes a thirddelegate_fmt_embedded_nodesbool,SyntaxNode::text()andtext_range()were renamed totext_with_trivia()andtext_range_with_trivia(),JsImportClausewas split into anAnyJsImportClauseunion, the source string is now read viaas_js_module_source().value_token().text_trimmed()(with manual unquoting), andAnyJsObjectMemberNamegained aJsMetavariablevariant for Grit support.The dependabot biome_* exclusion is also dropped so future updates flow through normally.
I didn't try to tweak the new formatter configuration, but this update is a breaking change as is, see brioche-dev/brioche-packages#5055 for the new formatting.