refactor(reporter): split JobsComponent rendering, fix build summary placement#486
Open
jaudiger wants to merge 2 commits into
Open
refactor(reporter): split JobsComponent rendering, fix build summary placement#486jaudiger wants to merge 2 commits into
jaudiger wants to merge 2 commits into
Conversation
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two commits on the console reporter.
The first commit splits
JobsComponent::draw_uncheckedinto smaller pieces. The draw function used to do everything inline; it now delegates tocompute_visible_jobs, anOutputsComponent, and arender_summarymethod. The visible behavior is unchanged.The second commit fixes the placement of the
Build finishedandResultlines frombrioche buildandbrioche install. They used to be emitted through the reporter, so they landed above the TUI canvas, in the middle of the terminal output. They are now printed witheprintln!aftershutdown_console, so they land below the canvas, likebrioche runandbrioche live-updatealready do.Before (
brioche buildonaws_c_auth):After (
brioche buildonaws_c_common):