Skip to content

Commit f8d606e

Browse files
committed
refactor: rename internal signal modules
1 parent 0645947 commit f8d606e

6 files changed

Lines changed: 105 additions & 105 deletions

File tree

packages/rescript-signals/src/signals/Signals__Computed.res

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ let makeWithoutEquals = (
22
compute: unit => 'a,
33
~name: option<string>=?,
44
): Signals__Signal.t<'a> => {
5-
let id = Id.make()
5+
let id = Signals__Id.make()
66
let equalsFn: ('a, 'a) => bool = (_a, _b) => false
77

88
// Create a mutable ref to hold the signal so the compute function can update it
@@ -18,13 +18,13 @@ let makeWithoutEquals = (
1818
}
1919

2020
// Create combined subs (this IS the observer for the computed)
21-
let subs = Core.makeComputedSubs(recompute, ~deferEffectsUntilRecompute=false)
21+
let subs = Signals__Core.makeComputedSubs(recompute, ~deferEffectsUntilRecompute=false)
2222

2323
// Initial computation under tracking to establish dependencies
24-
let prev = Scheduler.currentComputedSubs.contents
25-
Scheduler.currentComputedSubs := Some(subs)
24+
let prev = Signals__Scheduler.currentComputedSubs.contents
25+
Signals__Scheduler.currentComputedSubs := Some(subs)
2626
let initialValue = compute()
27-
Scheduler.currentComputedSubs := prev
27+
Signals__Scheduler.currentComputedSubs := prev
2828

2929
// Create the signal with the initial value
3030
let signal: Signals__Signal.t<'a> = {
@@ -37,8 +37,8 @@ let makeWithoutEquals = (
3737

3838
// Set the ref so recompute can access the signal
3939
signalRef := signal
40-
subs.lastGlobalVersion = Core.globalVersion.contents
41-
Core.clearSubsDirty(subs)
40+
subs.lastGlobalVersion = Signals__Core.globalVersion.contents
41+
Signals__Core.clearSubsDirty(subs)
4242

4343
signal
4444
}
@@ -48,7 +48,7 @@ let makeWithEquals = (
4848
equalsFn: ('a, 'a) => bool,
4949
~name: option<string>=?,
5050
): Signals__Signal.t<'a> => {
51-
let id = Id.make()
51+
let id = Signals__Id.make()
5252

5353
// Create a mutable ref to hold the signal so the compute function can update it
5454
// Using Obj.magic to avoid Option wrapper overhead
@@ -71,13 +71,13 @@ let makeWithEquals = (
7171
}
7272

7373
// Create combined subs (this IS the observer for the computed)
74-
let subs = Core.makeComputedSubs(recompute, ~deferEffectsUntilRecompute=true)
74+
let subs = Signals__Core.makeComputedSubs(recompute, ~deferEffectsUntilRecompute=true)
7575

7676
// Initial computation under tracking to establish dependencies
77-
let prev = Scheduler.currentComputedSubs.contents
78-
Scheduler.currentComputedSubs := Some(subs)
77+
let prev = Signals__Scheduler.currentComputedSubs.contents
78+
Signals__Scheduler.currentComputedSubs := Some(subs)
7979
let initialValue = compute()
80-
Scheduler.currentComputedSubs := prev
80+
Signals__Scheduler.currentComputedSubs := prev
8181

8282
// Create the signal with the initial value
8383
let signal: Signals__Signal.t<'a> = {
@@ -90,8 +90,8 @@ let makeWithEquals = (
9090

9191
// Set the ref so recompute can access the signal
9292
signalRef := signal
93-
subs.lastGlobalVersion = Core.globalVersion.contents
94-
Core.clearSubsDirty(subs)
93+
subs.lastGlobalVersion = Signals__Core.globalVersion.contents
94+
Signals__Core.clearSubsDirty(subs)
9595

9696
signal
9797
}
@@ -107,5 +107,5 @@ let make = (
107107
}
108108

109109
let dispose = (signal: Signals__Signal.t<'a>): unit => {
110-
Core.clearSubsDeps(signal.subs)
110+
Signals__Core.clearSubsDeps(signal.subs)
111111
}
File renamed without changes.

packages/rescript-signals/src/signals/Signals__Effect.res

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
type disposer = {dispose: unit => unit}
22

33
let runWithDisposer = (fn: unit => option<unit => unit>, ~name: option<string>=?): disposer => {
4-
let observerId = Id.make()
4+
let observerId = Signals__Id.make()
55
let cleanup: ref<option<unit => unit>> = ref(None)
66

77
// Wrapper that handles cleanup
@@ -17,24 +17,24 @@ let runWithDisposer = (fn: unit => option<unit => unit>, ~name: option<string>=?
1717
}
1818

1919
// Create observer using Core types
20-
let observer = Core.makeObserver(observerId, #Effect, runWithCleanup, ~name?)
20+
let observer = Signals__Core.makeObserver(observerId, #Effect, runWithCleanup, ~name?)
2121

2222
// Initial run under tracking (no need to clearDeps - observer is fresh)
23-
let prev = Scheduler.currentObserver.contents
24-
Scheduler.currentObserver := Some(observer)
23+
let prev = Signals__Scheduler.currentObserver.contents
24+
Signals__Scheduler.currentObserver := Some(observer)
2525

2626
try {
2727
observer.run()
28-
Core.clearDirty(observer)
29-
Scheduler.currentObserver := prev
28+
Signals__Core.clearDirty(observer)
29+
Signals__Scheduler.currentObserver := prev
3030
} catch {
3131
| exn =>
32-
Scheduler.currentObserver := prev
32+
Signals__Scheduler.currentObserver := prev
3333
throw(exn)
3434
}
3535

3636
// Compute level
37-
observer.level = Scheduler.computeLevel(observer)
37+
observer.level = Signals__Scheduler.computeLevel(observer)
3838

3939
// Return disposer - stores observer reference directly (no Map lookup needed)
4040
let disposed = ref(false)
@@ -49,7 +49,7 @@ let runWithDisposer = (fn: unit => option<unit => unit>, ~name: option<string>=?
4949
| None => ()
5050
}
5151

52-
Core.clearDeps(observer)
52+
Signals__Core.clearDeps(observer)
5353
}
5454
}
5555

File renamed without changes.

0 commit comments

Comments
 (0)