Ci benchmark workflows#28
Conversation
ReScript Signals benchmark: PR vs mainCompared implementations:
Overall:
Per-test delta (lower is better):
Note: single-machine run in CI. Numbers can vary with runner load and Node/V8 version. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4886daa71c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cat benchmark-results/ci/pr-vs-frameworks/pr-comment-latest.md >> "$GITHUB_STEP_SUMMARY" | ||
|
|
||
| - name: Upsert PR benchmark comment | ||
| if: github.event_name == 'pull_request' |
There was a problem hiding this comment.
Guard PR comment upsert against fork pull requests
This step runs for every pull_request event, but forked PRs get a read-only GITHUB_TOKEN; in that context, the github.rest.issues.*Comment calls fail with 403 and the benchmark job is marked failed even though benchmarking succeeded. Add a fork-aware condition (for example, skip when github.event.pull_request.head.repo.fork is true) or move comment writing to a trusted workflow context; the same pattern is also present in .github/workflows/benchmark-pr-vs-main.yml.
Useful? React with 👍 / 👎.
| run: npm run build | ||
|
|
||
| - name: Clone benchmark suite | ||
| run: git clone --depth=1 https://github.com/milomg/js-reactivity-benchmark.git .tmp/js-reactivity-benchmark |
There was a problem hiding this comment.
Pin benchmark suite revision before cloning
The workflow clones milomg/js-reactivity-benchmark from its moving default branch, so upstream changes can break this repo’s PR checks without any change here. That risk is concrete in this commit because scripts/ci/benchmark-pr-vs-frameworks.mjs expects specific framework names and throws if they change. Cloning a fixed tag or commit SHA will make CI results reproducible and prevent flaky external breakages.
Useful? React with 👍 / 👎.
Reactivity benchmark: PR vs top frameworksCompared implementations:
Overall ranking (lower total ms is better):
Per-test runtime (ms):
Note: single-machine run in CI. Numbers can vary with runner load and Node/V8 version. |
No description provided.