Merge pull request #557 from brooklyn-data/bug/fix-ci

Bug: Fix CI Error In Production

Author: mtcarlone

.github/workflows/cut-release-candidate.yml

@@ -41,6 +41,15 @@ concurrency:
   group: cut-release-candidate
   cancel-in-progress: false
 
+env:
+  # Temporary: keep Node 20 as the actions runtime so the currently
+  # SHA-pinned action versions (which are Node 20-based) keep working
+  # after the June 2, 2026 default flip to Node 24. HARD DEADLINE:
+  # September 16, 2026, when Node 20 is removed from the runner entirely.
+  # Remove this once the pinned actions are bumped to Node 24-compatible
+  # versions. Tracked in specs/ci-rework/README.md §12.5.
+  ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: "true"
+
 jobs:
   cut:
     runs-on: ubuntu-latest

.github/workflows/main.yml

@@ -41,6 +41,14 @@ concurrency:
   cancel-in-progress: false
 
 env:
+  # Temporary: keep Node 20 as the actions runtime so the currently
+  # SHA-pinned action versions (which are Node 20-based) keep working
+  # after the June 2, 2026 default flip to Node 24. HARD DEADLINE:
+  # September 16, 2026, when Node 20 is removed from the runner entirely.
+  # Remove this once the pinned actions are bumped to Node 24-compatible
+  # versions. Tracked in specs/ci-rework/README.md §12.5.
+  ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: "true"
+
   # Non-secret env vars consumed by the dbt invocations test model. These
   # are the same values used pre-rework and are checked in to profiles.yml
   # via env_var() — they need to be present, not secret.

.github/workflows/pr.yml

@@ -39,6 +39,15 @@ concurrency:
   group: tier1-${{ github.event.pull_request.number }}
   cancel-in-progress: true
 
+env:
+  # Temporary: keep Node 20 as the actions runtime so the currently
+  # SHA-pinned action versions (which are Node 20-based) keep working
+  # after the June 2, 2026 default flip to Node 24. HARD DEADLINE:
+  # September 16, 2026, when Node 20 is removed from the runner entirely.
+  # Remove this once the pinned actions are bumped to Node 24-compatible
+  # versions. Tracked in specs/ci-rework/README.md §12.5.
+  ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: "true"
+
 jobs:
   integration-local:
     name: integration (${{ matrix.warehouse }})

.github/workflows/release.yml

@@ -51,6 +51,14 @@ concurrency:
   cancel-in-progress: false
 
 env:
+  # Temporary: keep Node 20 as the actions runtime so the currently
+  # SHA-pinned action versions (which are Node 20-based) keep working
+  # after the June 2, 2026 default flip to Node 24. HARD DEADLINE:
+  # September 16, 2026, when Node 20 is removed from the runner entirely.
+  # Remove this once the pinned actions are bumped to Node 24-compatible
+  # versions. Tracked in specs/ci-rework/README.md §12.5.
+  ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: "true"
+
   # Non-secret env vars consumed by the invocations test model (see
   # integration_test_project/profiles.yml).
   DBT_CLOUD_PROJECT_ID: 123

compose.yml

@@ -96,9 +96,13 @@ services:
       /opt/mssql-tools18/bin/sqlcmd -S sqlserver -U sa -P ${MSSQL_SA_PASSWORD:-123Administrator} -No -d master -i docker-entrypoint-initdb.d/init.sql
       && echo "SQL Server bootstrap complete.";
       '
-    # The configurator exits after init.sql completes; that exit is success.
-    # `docker compose up --wait` treats a service as healthy when it has no
-    # healthcheck and exits 0, so this satisfies the wait without a healthcheck.
+    # This is a run-to-completion init container: it runs init.sql, prints
+    # the success message, and exits. Crucially, it is NOT compatible with
+    # `docker compose up --wait` — `--wait` treats "not running" as a
+    # failure regardless of exit code, so a container that exits cleanly
+    # still makes `--wait` return non-zero. `scripts/ci/compose-up.sh`
+    # handles that by bringing init containers up separately and using
+    # `docker compose wait` (different command) to block on their exit.
 
 volumes:
   postgres_data:

models/dim_dbt__current_models.sql

@@ -1,10 +1,12 @@
 with
     base as (select * from {{ ref("stg_dbt__models") }}),
+
     model_executions as (select * from {{ ref("stg_dbt__model_executions") }}),
+
     latest_models as (
 
         {# Retrieves the models present in the most recent run #}
-        select * from base where run_started_at = (select max(run_started_at) from base)
+        select * from base where run_started_at = (select max(b.run_started_at) from base as b)
 
     ),
 
@@ -132,4 +134,3 @@ with
 
 select *
 from final
-

models/staging/stg_dbt__model_executions.sql

@@ -1,5 +1,6 @@
 with
     base as (select * from {{ ref("model_executions") }}),
+
     enhanced as (
 
         select
@@ -30,4 +31,3 @@ with
 
 select *
 from enhanced
-

models/staging/stg_dbt__models.sql

@@ -1,5 +1,6 @@
 with
     base as (select * from {{ ref("models") }}),
+
     enhanced as (
 
         select
@@ -29,4 +30,3 @@ with
 
 select *
 from enhanced
-

models/staging/stg_dbt__seed_executions.sql

@@ -1,5 +1,6 @@
 with
     base as (select * from {{ ref("seed_executions") }}),
+
     enhanced as (
 
         select
@@ -29,4 +30,3 @@ with
 
 select *
 from enhanced
-

models/staging/stg_dbt__seeds.sql

@@ -1,5 +1,6 @@
 with
     base as (select * from {{ ref("seeds") }}),
+
     enhanced as (
 
         select
@@ -26,4 +27,3 @@ with
 
 select *
 from enhanced
-