chore: merge task/todo-12-selectmcpjsondir-test — add unit tests for selectMcpJsonDir (TODO johannesjo#12)

Author: brooksc

electron/ipc/register.test.ts

@@ -0,0 +1,16 @@
+import { describe, expect, it } from 'vitest';
+import { selectMcpJsonDir } from './register.js';
+
+describe('selectMcpJsonDir', () => {
+  it('returns worktreePath when defined', () => {
+    expect(selectMcpJsonDir('/worktrees/my-task', '/project')).toBe('/worktrees/my-task');
+  });
+
+  it('returns projectRoot when worktreePath is undefined', () => {
+    expect(selectMcpJsonDir(undefined, '/project')).toBe('/project');
+  });
+
+  it('returns empty string when worktreePath is empty string (nullish coalescing only catches null/undefined)', () => {
+    expect(selectMcpJsonDir('', '/project')).toBe('');
+  });
+});

src/store/tasks.test.ts

@@ -54,6 +54,7 @@ vi.mock('./core', () => ({
       if (prop === 'agents') return mockAgents;
       if (prop === 'taskOrder') return mockTaskOrder;
       if (prop === 'collapsedTaskOrder') return [];
+      if (prop === 'availableAgents') return [];
       return undefined;
     },
   }),

src/store/tasks.ts

@@ -912,18 +912,22 @@ export function initMCPListeners(): () => void {
         skipPermissions: evt.skipPermissions ?? false,
       };
 
+      const cmd = evt.agentCommand ?? 'claude';
+      const matchedDef = store.availableAgents?.find((a) => a.command === cmd);
+      const agentDef = matchedDef ?? {
+        id: cmd,
+        name: cmd,
+        command: cmd,
+        args: evt.agentArgs ?? [],
+        resume_args: [],
+        skip_permissions_args: ['--dangerously-skip-permissions'],
+        description: '',
+      };
+
       const agent: Agent = {
         id: evt.agentId,
         taskId: evt.taskId,
-        def: {
-          id: 'claude',
-          name: 'Claude Code',
-          command: evt.agentCommand ?? 'claude',
-          args: evt.agentArgs ?? [],
-          resume_args: [],
-          skip_permissions_args: ['--dangerously-skip-permissions'],
-          description: '',
-        },
+        def: matchedDef ? { ...matchedDef, args: evt.agentArgs ?? matchedDef.args } : agentDef,
         resumed: false,
         status: 'running',
         exitCode: null,