Skip to content

Commit adeeb11

Browse files
committed
chore: mark TODO johannesjo#18 complete (docker exec inner process cleanup)
1 parent c04a2fe commit adeeb11

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

TODOS.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,6 @@
4343
**What's wrong:** `mcpConfigPath` is persisted and rewritten on app restart, but if the coordinator Claude process itself restarts, the MCP token changes and running sub-tasks become unreachable.
4444
**No fix yet** — edge case.
4545

46-
### 18. Docker sub-agent process cleanup is shaky
47-
48-
**File:** `electron/mcp/coordinator.ts:507`
49-
**What's wrong:** Sub-agents spawned via `docker exec` are not marked `dockerMode` with a `containerName`. Killing the PTY stops the host `docker exec` client but may leave the inner agent process running inside the coordinator container.
50-
**Done when:** Docker-exec PTY sessions are marked with the coordinator `containerName` and a `SIGTERM` is sent to the inner process via `docker exec <container> kill <pid>` on cleanup.
51-
5246
### ~~25. Remote server started without coordinator routes when remote access precedes coordinator~~ ✅ COMPLETE
5347

5448
Already resolved by TODO #14's lazy `getCoordinator()` pattern. All coordinator routes are registered at server startup and call `opts.getCoordinator()` at request time, returning 503 when null. Test coverage added in `electron/remote/coordinator-scoping.test.ts`.

0 commit comments

Comments
 (0)