Merge pull request #30 from browser-use/subagents-codex-runtime-parity

Much better subagent system

Author: exe-dev-github-integration[bot]

crates/browser-use-agent/src/compact/tests.rs

@@ -433,6 +433,7 @@ impl SamplingDriver for LoopSampler {
             .unwrap_or_else(|| SamplingOutcome {
                 model_needs_follow_up: false,
                 last_agent_message: Some("end".to_string()),
+                defers_mailbox_delivery_to_next_turn: true,
                 finish_reason: None,
             }))
     }
@@ -481,13 +482,15 @@ fn follow_up(msg: &str) -> SamplingOutcome {
     SamplingOutcome {
         model_needs_follow_up: true,
         last_agent_message: Some(msg.to_string()),
+        defers_mailbox_delivery_to_next_turn: false,
         finish_reason: None,
     }
 }
 fn complete(msg: &str) -> SamplingOutcome {
     SamplingOutcome {
         model_needs_follow_up: false,
         last_agent_message: Some(msg.to_string()),
+        defers_mailbox_delivery_to_next_turn: true,
         finish_reason: None,
     }
 }

crates/browser-use-agent/src/compact/threshold_tests.rs

@@ -264,6 +264,7 @@ fn follow_up(msg: &str) -> SamplingOutcome {
     SamplingOutcome {
         model_needs_follow_up: true,
         last_agent_message: Some(msg.to_string()),
+        defers_mailbox_delivery_to_next_turn: false,
         finish_reason: None,
     }
 }
@@ -272,6 +273,7 @@ fn complete(msg: &str) -> SamplingOutcome {
     SamplingOutcome {
         model_needs_follow_up: false,
         last_agent_message: Some(msg.to_string()),
+        defers_mailbox_delivery_to_next_turn: true,
         finish_reason: None,
     }
 }

crates/browser-use-agent/src/config_overrides.rs

@@ -714,6 +714,53 @@ impl ProviderRunConfig {
     }
 }
 
+/// Re-apply runtime options that were snapshotted into a
+/// [`ChildAgentRunRequest`]. Child wake/resume paths may run under a different
+/// parent process/config than the original spawn, so these values must travel
+/// with the child run marker rather than relying on the current parent config.
+pub fn apply_child_request_runtime_config(
+    config: &mut ProviderRunConfig,
+    request: &ChildAgentRunRequest,
+) -> Result<()> {
+    let overrides = &request.config_overrides;
+    if let Some(value) = config_override_str(overrides, "browser_mode") {
+        config.options.browser_mode = Some(value);
+    }
+    if let Some(value) = config_override_str(overrides, "base_instructions") {
+        config.options.base_instructions = Some(value);
+    }
+    if let Some(value) = config_override_str(overrides, "developer_instructions") {
+        config.options.developer_instructions = Some(value);
+    }
+    if let Some(value) = config_override_str(overrides, "compact_prompt") {
+        config.options.compact_prompt = Some(value);
+    }
+    if let Some(value) = config_override_u64(overrides, "python_tool_timeout_seconds") {
+        config.options.python_tool_timeout_seconds = value;
+    }
+    if let Some(value) = config_override_bool(overrides, "model_compaction_enabled") {
+        config.options.model_compaction_enabled = value;
+    }
+    if let Some(value) = config_override_i64(overrides, "model_auto_compact_token_limit") {
+        config.options.model_auto_compact_token_limit = Some(value);
+    }
+    if let Some(value) = config_override_str(overrides, "model_auto_compact_token_limit_scope") {
+        config.options.model_auto_compact_token_limit_scope =
+            parse_auto_compact_token_limit_scope(&value)?;
+    }
+    if let Some(value) = config_override_str(overrides, "approval_policy")
+        .or_else(|| config_override_str(overrides, "ask_for_approval"))
+    {
+        config.options.approval_policy = parse_approval_policy(&value)?;
+    }
+    if let Some(value) = config_override_bool(overrides, "use_guardian")
+        .or_else(|| config_override_bool(overrides, "guardian"))
+    {
+        config.options.use_guardian = value;
+    }
+    Ok(())
+}
+
 /// Parse raw `key=value` override strings into an ordered [`ConfigOverrides`].
 ///
 /// Behavior is byte-identical to `browser-use-core::parse_config_overrides`
@@ -1484,6 +1531,28 @@ fn config_override_bool(overrides: &ConfigOverrides, key: &str) -> Option<bool>
         .and_then(|(_, value)| value.as_bool())
 }
 
+fn config_override_i64(overrides: &ConfigOverrides, key: &str) -> Option<i64> {
+    overrides
+        .iter()
+        .rev()
+        .find(|(candidate, _)| candidate == key)
+        .and_then(|(_, value)| value.as_integer())
+}
+
+fn config_override_u64(overrides: &ConfigOverrides, key: &str) -> Option<u64> {
+    config_override_i64(overrides, key).and_then(|value| u64::try_from(value).ok())
+}
+
+fn parse_auto_compact_token_limit_scope(raw: &str) -> Result<AutoCompactTokenLimitScope> {
+    match raw.trim().to_ascii_lowercase().replace('-', "_").as_str() {
+        "total" => Ok(AutoCompactTokenLimitScope::Total),
+        "body_after_prefix" | "bodyafterprefix" => Ok(AutoCompactTokenLimitScope::BodyAfterPrefix),
+        other => bail!(
+            "invalid model_auto_compact_token_limit_scope {other:?}; expected total or body_after_prefix"
+        ),
+    }
+}
+
 /// Mirrors `browser-use-core::canonicalize_config_override_key`
 /// (`config_overrides.rs:35`).
 fn canonicalize_config_override_key(key: &str) -> String {

crates/browser-use-agent/src/decision/loop_decision.rs

@@ -18,6 +18,10 @@ pub struct SamplingOutcome {
     /// `turn.rs:250`.
     pub model_needs_follow_up: bool,
     pub last_agent_message: Option<String>,
+    /// Codex defers inter-agent mailbox delivery only after output that closes a
+    /// turn boundary, such as final assistant text. Commentary text remains a
+    /// current-turn preemption/drain point.
+    pub defers_mailbox_delivery_to_next_turn: bool,
     pub finish_reason: Option<FinishReason>,
 }
 
@@ -198,6 +202,7 @@ mod tests {
         SamplingOutcome {
             model_needs_follow_up: model_nfu,
             last_agent_message: None,
+            defers_mailbox_delivery_to_next_turn: false,
             finish_reason: None,
         }
     }