Remove borrow injection from translated runtimes

Author: pirate

go/modcdp/client/ModCDPClient.go

@@ -78,7 +78,6 @@ type RouterConfig = types.ModCDPRouterConfig
 type ExtensionInjector = injector.ExtensionInjector
 type DiscoverExtensionInjector = injector.DiscoverExtensionInjector
 type BBExtensionInjector = injector.BBExtensionInjector
-type BorrowExtensionInjector = injector.BorrowExtensionInjector
 type CLIExtensionInjector = injector.CLIExtensionInjector
 type CDPExtensionInjector = injector.CDPExtensionInjector
 type UpstreamMode = transportpkg.UpstreamMode
@@ -96,7 +95,6 @@ var NewBBBrowserLauncher = launcher.NewBBBrowserLauncher
 var NewNoneBrowserLauncher = launcher.NewNoneBrowserLauncher
 var NewDiscoverExtensionInjector = injector.NewDiscoverExtensionInjector
 var NewBBExtensionInjector = injector.NewBBExtensionInjector
-var NewBorrowExtensionInjector = injector.NewBorrowExtensionInjector
 var NewCLIExtensionInjector = injector.NewCLIExtensionInjector
 var NewCDPExtensionInjector = injector.NewCDPExtensionInjector
 var NewWSUpstreamTransport = transportpkg.NewWSUpstreamTransport
@@ -1132,10 +1130,6 @@ func (c *ModCDPClient) extensionInjectorsForConfig() ([]extensionInjector, *Exte
 		injector := NewBBExtensionInjector(InjectorConfig{})
 		return []extensionInjector{&injector}, &injector.ExtensionInjector
 	}
-	if c.Config.Injector.InjectorMode == "borrow" {
-		injector := NewBorrowExtensionInjector(InjectorConfig{})
-		return []extensionInjector{&injector}, &injector.ExtensionInjector
-	}
 	if c.Config.Injector.InjectorMode == "discover" {
 		injector := NewDiscoverExtensionInjector(InjectorConfig{})
 		return []extensionInjector{&injector}, &injector.ExtensionInjector
@@ -1152,7 +1146,7 @@ func isKnownUpstreamMode(mode string) bool {
 }
 
 func isKnownExtensionMode(mode string) bool {
-	return mode == "cli" || mode == "cdp" || mode == "bb" || mode == "borrow" || mode == "discover" || mode == "none"
+	return mode == "cli" || mode == "cdp" || mode == "bb" || mode == "discover" || mode == "none"
 }
 
 func (c *ModCDPClient) baseInjectorConfig(send SendCDP) InjectorConfig {
@@ -1165,7 +1159,6 @@ func (c *ModCDPClient) baseInjectorConfig(send SendCDP) InjectorConfig {
 		InjectorCDPExtensionID:               c.Config.Injector.InjectorCDPExtensionID,
 		InjectorBBExtensionPath:              c.Config.Injector.InjectorBBExtensionPath,
 		InjectorBBExtensionID:                c.Config.Injector.InjectorBBExtensionID,
-		InjectorBorrowExtensionPath:          c.Config.Injector.InjectorBorrowExtensionPath,
 		InjectorDiscoverExtensionPath:        c.Config.Injector.InjectorDiscoverExtensionPath,
 		InjectorServiceWorkerExtensionID:     c.Config.Injector.InjectorServiceWorkerExtensionID,
 		InjectorServiceWorkerURLIncludes:     c.Config.Injector.InjectorServiceWorkerURLIncludes,

go/modcdp/injector/BorrowExtensionInjector.go

@@ -94,9 +94,6 @@ func (i *ExtensionInjector) Update(config InjectorConfig) *ExtensionInjector {
 	if config.InjectorBBExtensionID != "" {
 		i.Config.InjectorBBExtensionID = config.InjectorBBExtensionID
 	}
-	if config.InjectorBorrowExtensionPath != "" {
-		i.Config.InjectorBorrowExtensionPath = config.InjectorBorrowExtensionPath
-	}
 	if config.InjectorDiscoverExtensionPath != "" {
 		i.Config.InjectorDiscoverExtensionPath = config.InjectorDiscoverExtensionPath
 	}

go/modcdp/injector/BorrowExtensionInjector_test.go

@@ -35,7 +35,6 @@ type ExtensionInjector = injector.ExtensionInjector
 type PreparedExtension = injector.PreparedExtension
 type DiscoverExtensionInjector = injector.DiscoverExtensionInjector
 type BBExtensionInjector = injector.BBExtensionInjector
-type BorrowExtensionInjector = injector.BorrowExtensionInjector
 type CLIExtensionInjector = injector.CLIExtensionInjector
 type CDPExtensionInjector = injector.CDPExtensionInjector
 type UpstreamMode = transport.UpstreamMode
@@ -97,7 +96,6 @@ var ResolveCdpWebSocketUrl = launcher.WebsocketURLFor
 var NewExtensionInjector = injector.NewExtensionInjector
 var NewDiscoverExtensionInjector = injector.NewDiscoverExtensionInjector
 var NewBBExtensionInjector = injector.NewBBExtensionInjector
-var NewBorrowExtensionInjector = injector.NewBorrowExtensionInjector
 var NewCLIExtensionInjector = injector.NewCLIExtensionInjector
 var NewCDPExtensionInjector = injector.NewCDPExtensionInjector
 var DefaultModCDPExtensionPath = injector.DefaultModCDPExtensionPath

go/modcdp/injector/ExtensionInjector.go

@@ -24,10 +24,9 @@ func TestRootExportsConcreteLaunchersInjectorsAndTransports(t *testing.T) {
 	extensionInjector := NewExtensionInjector(InjectorConfig{})
 	discoveredInjector := NewDiscoverExtensionInjector(InjectorConfig{})
 	bbInjector := NewBBExtensionInjector(InjectorConfig{})
-	borrowInjector := NewBorrowExtensionInjector(InjectorConfig{})
 	localLaunchInjector := NewCLIExtensionInjector(InjectorConfig{})
 	loadUnpackedInjector := NewCDPExtensionInjector(InjectorConfig{})
-	_ = []any{extensionInjector, discoveredInjector, bbInjector, borrowInjector, localLaunchInjector, loadUnpackedInjector}
+	_ = []any{extensionInjector, discoveredInjector, bbInjector, localLaunchInjector, loadUnpackedInjector}
 
 	if NewUpstreamTransport(UpstreamTransportConfig{}).Config.UpstreamMode != string(UpstreamModeWS) {
 		t.Fatal("NewUpstreamTransport did not hydrate default ws mode")

go/modcdp/modcdp.go

@@ -68,7 +68,6 @@ type InjectorConfig struct {
 	InjectorCDPExtensionID               string   `json:"injector_cdp_extension_id,omitempty"`
 	InjectorBBExtensionPath              string   `json:"injector_bb_extension_path,omitempty"`
 	InjectorBBExtensionID                string   `json:"injector_bb_extension_id,omitempty"`
-	InjectorBorrowExtensionPath          string   `json:"injector_borrow_extension_path,omitempty"`
 	InjectorDiscoverExtensionPath        string   `json:"injector_discover_extension_path,omitempty"`
 	InjectorServiceWorkerExtensionID     string   `json:"injector_service_worker_extension_id,omitempty"`
 	InjectorServiceWorkerURLIncludes     []string `json:"injector_service_worker_url_includes,omitempty"`

go/modcdp/modcdp_test.go

@@ -1,7 +1,5 @@
-// MODCDP_TRANSLATE: KEEP THIS FILE TRANSLATED ACROSS TYPESCRIPT, PYTHON, AND GO.
-// Keep all shapes, signatures, behavior, and tests 1:1 in sync with:
-// - ./python/modcdp/injector/BorrowExtensionInjector.py
-// - ./go/modcdp/injector/BorrowExtensionInjector.go
+// MODCDP_TS_ONLY: DO NOT TRANSLATE THIS FILE TO OTHER LANGUAGES.
+// Reason: not needed by Stagehand.
 import fs from "node:fs";
 import path from "node:path";
 import * as Runtime from "../types/generated/zod/Runtime.js";