Skip to content

Commit 3303841

Browse files
derekmeeganclaude
andcommitted
fix: revert pydantic v2 extra="ignore" and update ExtensionRetrieveResponse usage
Reverts the change from 9cae18c that set extra="ignore" in pydantic v2, which caused unknown/extra API fields to be silently dropped. Also updates examples to use the consolidated Extension type instead of the removed ExtensionRetrieveResponse. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent b45ce50 commit 3303841

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

examples/playwright_extensions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
BROWSERBASE_PROJECT_ID,
1111
bb,
1212
)
13-
from browserbase.types import SessionCreateResponse, ExtensionRetrieveResponse
13+
from browserbase.types import SessionCreateResponse, Extension
1414

1515
PATH_TO_EXTENSION = Path.cwd() / "examples" / "packages" / "extensions" / "browserbase-test"
1616

@@ -51,7 +51,7 @@ def create_extension() -> str:
5151
return extension.id
5252

5353

54-
def get_extension(id: str) -> ExtensionRetrieveResponse:
54+
def get_extension(id: str) -> Extension:
5555
return bb.extensions.retrieve(id)
5656

5757

src/browserbase/_models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ class Config(pydantic.BaseConfig): # pyright: ignore[reportDeprecated]
107107
extra: Any = pydantic.Extra.allow # type: ignore
108108
else:
109109
model_config: ClassVar[ConfigDict] = ConfigDict(
110-
extra="ignore", defer_build=coerce_boolean(os.environ.get("DEFER_PYDANTIC_BUILD", "true"))
110+
extra="allow", defer_build=coerce_boolean(os.environ.get("DEFER_PYDANTIC_BUILD", "true"))
111111
)
112112

113113
def to_dict(

0 commit comments

Comments
 (0)