always detatch cdp

Author: pirate

src/stagehand/_custom/session.py

@@ -39,6 +39,9 @@ class _PlaywrightCDPSession(Protocol):
     def send(self, method: str, params: Any = ...) -> Any:  # noqa: ANN401
         ...
 
+    def detach(self) -> Any:  # noqa: ANN401
+        ...
+
 
 class _PlaywrightContext(Protocol):
     def new_cdp_session(self, page: Any) -> Any:  # noqa: ANN401
@@ -71,11 +74,21 @@ def _extract_frame_id_from_playwright_page(page: Any) -> str:
         raise StagehandError("Playwright CDP session missing .send(...) method")
 
     pw_cdp = cast(_PlaywrightCDPSession, cdp)
-    result = pw_cdp.send("Page.getFrameTree")
-    if inspect.isawaitable(result):
-        raise StagehandError(
-            "Expected a synchronous Playwright Page, but received an async CDP session; use AsyncSession methods"
-        )
+    try:
+        result = pw_cdp.send("Page.getFrameTree")
+        if inspect.isawaitable(result):
+            raise StagehandError(
+                "Expected a synchronous Playwright Page, but received an async CDP session; use AsyncSession methods"
+            )
+    finally:
+        detach = getattr(cdp, "detach", None)
+        if callable(detach):
+            try:
+                detach_result = detach()
+                if inspect.isawaitable(detach_result):
+                    logger.warning("Playwright sync CDP detach() returned an awaitable; session may remain open")
+            except Exception:  # noqa: BLE001
+                logger.debug("Failed to detach Playwright CDP session", exc_info=True)
 
     try:
         return cast(str, result["frameTree"]["frame"]["id"])
@@ -107,9 +120,19 @@ async def _extract_frame_id_from_playwright_page_async(page: Any) -> str:
         raise StagehandError("Playwright CDP session missing .send(...) method")
 
     pw_cdp = cast(_PlaywrightCDPSession, cdp)
-    result = pw_cdp.send("Page.getFrameTree")
-    if inspect.isawaitable(result):
-        result = await result
+    try:
+        result = pw_cdp.send("Page.getFrameTree")
+        if inspect.isawaitable(result):
+            result = await result
+    finally:
+        detach = getattr(cdp, "detach", None)
+        if callable(detach):
+            try:
+                detach_result = detach()
+                if inspect.isawaitable(detach_result):
+                    await detach_result
+            except Exception:  # noqa: BLE001
+                logger.debug("Failed to detach Playwright CDP session", exc_info=True)
 
     try:
         return cast(str, result["frameTree"]["frame"]["id"])

tests/test_session_page_param.py

@@ -19,18 +19,24 @@
 class _SyncCDP:
     def __init__(self, frame_id: str) -> None:
         self._frame_id = frame_id
+        self.detached = False
 
     def send(self, method: str) -> dict[str, Any]:
         assert method == "Page.getFrameTree"
         return {"frameTree": {"frame": {"id": self._frame_id}}}
 
+    def detach(self) -> None:
+        self.detached = True
+
 
 class _SyncContext:
     def __init__(self, frame_id: str) -> None:
         self._frame_id = frame_id
+        self.last_cdp: _SyncCDP | None = None
 
     def new_cdp_session(self, _page: Any) -> _SyncCDP:
-        return _SyncCDP(self._frame_id)
+        self.last_cdp = _SyncCDP(self._frame_id)
+        return self.last_cdp
 
 
 class _SyncPage:
@@ -41,18 +47,24 @@ def __init__(self, frame_id: str) -> None:
 class _AsyncCDP:
     def __init__(self, frame_id: str) -> None:
         self._frame_id = frame_id
+        self.detached = False
 
     async def send(self, method: str) -> dict[str, Any]:
         assert method == "Page.getFrameTree"
         return {"frameTree": {"frame": {"id": self._frame_id}}}
 
+    async def detach(self) -> None:
+        self.detached = True
+
 
 class _AsyncContext:
     def __init__(self, frame_id: str) -> None:
         self._frame_id = frame_id
+        self.last_cdp: _AsyncCDP | None = None
 
     async def new_cdp_session(self, _page: Any) -> _AsyncCDP:
-        return _AsyncCDP(self._frame_id)
+        self.last_cdp = _AsyncCDP(self._frame_id)
+        return self.last_cdp
 
 
 class _AsyncPage:
@@ -64,6 +76,7 @@ def __init__(self, frame_id: str) -> None:
 def test_session_act_injects_frame_id_from_page(respx_mock: MockRouter, client: Stagehand) -> None:
     session_id = "00000000-0000-0000-0000-000000000000"
     frame_id = "frame-123"
+    page = _SyncPage(frame_id)
 
     respx_mock.post("/v1/sessions/start").mock(
         return_value=httpx.Response(
@@ -80,9 +93,11 @@ def test_session_act_injects_frame_id_from_page(respx_mock: MockRouter, client:
     )
 
     session = client.sessions.start(model_name="openai/gpt-5-nano")
-    session.act(input="click something", page=_SyncPage(frame_id))
+    session.act(input="click something", page=page)
 
     assert act_route.called is True
+    assert page.context.last_cdp is not None
+    assert page.context.last_cdp.detached is True
     first_call = cast(Call, act_route.calls[0])
     request_body = json.loads(first_call.request.content)
     assert request_body["frameId"] == frame_id
@@ -129,6 +144,7 @@ async def test_async_session_act_injects_frame_id_from_page(
 ) -> None:
     session_id = "00000000-0000-0000-0000-000000000000"
     frame_id = "frame-async-456"
+    page = _AsyncPage(frame_id)
 
     respx_mock.post("/v1/sessions/start").mock(
         return_value=httpx.Response(
@@ -145,9 +161,11 @@ async def test_async_session_act_injects_frame_id_from_page(
     )
 
     session = await async_client.sessions.start(model_name="openai/gpt-5-nano")
-    await session.act(input="click something", page=_AsyncPage(frame_id))
+    await session.act(input="click something", page=page)
 
     assert act_route.called is True
+    assert page.context.last_cdp is not None
+    assert page.context.last_cdp.detached is True
     first_call = cast(Call, act_route.calls[0])
     request_body = json.loads(first_call.request.content)
     assert request_body["frameId"] == frame_id