AXE-3625: Reuse shared duplicate-id check for the aria variant (DRY)

Collapse the dedicated duplicate-id-aria evaluate/after back into the
shared duplicate-id-evaluate/duplicate-id-after, gated by a `reviewPayload`
check option. The aria check enables the bulk-review payload via that
option; the static/active checks keep their original string `data` and are
behaviourally unchanged. Adds tests for both data shapes and verdict parity.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: rajathmr2000

lib/checks/parsing/duplicate-id-after.js

@@ -1,8 +1,9 @@
 function duplicateIdAfter(results) {
   const uniqueIds = [];
   return results.filter(r => {
-    if (uniqueIds.indexOf(r.data) === -1) {
-      uniqueIds.push(r.data);
+    const id = r.data && typeof r.data === 'object' ? r.data.id : r.data;
+    if (uniqueIds.indexOf(id) === -1) {
+      uniqueIds.push(id);
       return true;
     }
     return false;

lib/checks/parsing/duplicate-id-aria-after.js

@@ -1,7 +1,8 @@
 {
   "id": "duplicate-id-aria",
-  "evaluate": "duplicate-id-aria-evaluate",
-  "after": "duplicate-id-aria-after",
+  "evaluate": "duplicate-id-evaluate",
+  "after": "duplicate-id-after",
+  "options": { "reviewPayload": true },
   "metadata": {
     "impact": "critical",
     "messages": {

lib/checks/parsing/duplicate-id-aria-evaluate.js

@@ -1,7 +1,7 @@
 import { getRootNode } from '../../commons/dom';
 import { escapeSelector } from '../../core/utils';
 
-function duplicateIdEvaluate(node) {
+function duplicateIdEvaluate(node, options = {}) {
   const id = node.getAttribute('id').trim();
   // Since empty ID's are not meaningful and are ignored by Edge, we'll
   // let those pass.
@@ -16,6 +16,28 @@ function duplicateIdEvaluate(node) {
   if (matchingNodes.length) {
     this.relatedNodes(matchingNodes);
   }
+
+  if (options.reviewPayload) {
+    const verdict = matchingNodes.length === 0;
+    const data = { id };
+    try {
+      if (matchingNodes.length) {
+        data.reviewPayload = {
+          visualHelperData: {
+            duplicateId: id,
+            elements: matchingNodes
+              .filter(Boolean)
+              .map(foundNode => new axe.utils.DqElement(foundNode).selector)
+          }
+        };
+      }
+    } catch {
+      // best-effort emit — preserve the scan result
+    }
+    this.data(data);
+    return verdict;
+  }
+
   this.data(id);
 
   return matchingNodes.length === 0;

lib/checks/parsing/duplicate-id-aria.json

@@ -5,6 +5,8 @@ describe('duplicate-id-aria', function () {
   var fixtureSetup = axe.testUtils.fixtureSetup;
   var checkContext = axe.testUtils.MockCheckContext();
   var checkEvaluate = axe.testUtils.getCheckEvaluate('duplicate-id-aria');
+  // duplicate-id-aria enables the bulk-review payload via this check option
+  var options = { reviewPayload: true };
 
   afterEach(function () {
     fixture.innerHTML = '';
@@ -15,7 +17,7 @@ describe('duplicate-id-aria', function () {
   it('returns true and emits no reviewPayload when the id is unique', function () {
     fixtureSetup('<div id="solo"></div>');
     var node = fixture.querySelector('#solo');
-    assert.isTrue(checkEvaluate.call(checkContext, node));
+    assert.isTrue(checkEvaluate.call(checkContext, node, options));
     assert.equal(checkContext._data.id, 'solo');
     assert.notProperty(checkContext._data, 'reviewPayload');
     assert.deepEqual(checkContext._relatedNodes, []);
@@ -26,7 +28,7 @@ describe('duplicate-id-aria', function () {
       '<div id="dup"></div><div id="dup"></div><div id="dup"></div>'
     );
     var node = fixture.querySelector('div');
-    assert.isFalse(checkEvaluate.call(checkContext, node));
+    assert.isFalse(checkEvaluate.call(checkContext, node, options));
 
     assert.equal(checkContext._data.id, 'dup');
     var visualHelperData = checkContext._data.reviewPayload.visualHelperData;
@@ -38,6 +40,16 @@ describe('duplicate-id-aria', function () {
     assert.isString(visualHelperData.elements[0][0]);
   });
 
+  it('emits additively — the reviewPayload option does not change the verdict', function () {
+    fixtureSetup('<div id="dup"></div><div id="dup"></div>');
+    var node = fixture.querySelector('div');
+    var withOption = checkEvaluate.call(checkContext, node, options);
+    checkContext.reset();
+    var withoutOption = checkEvaluate.call(checkContext, node, {});
+    assert.equal(withOption, withoutOption);
+    assert.isFalse(withOption);
+  });
+
   it('after dedupes results by data.id', function () {
     var results = checks['duplicate-id-aria'].after([
       { data: { id: 'a' } },

lib/checks/parsing/duplicate-id-evaluate.js

@@ -31,6 +31,19 @@ describe('duplicate-id', function () {
     assert.deepEqual(checkContext._relatedNodes, [node.nextSibling]);
   });
 
+  it('keeps data a plain id string and emits no reviewPayload when the reviewPayload option is off', function () {
+    // Guards the static/active duplicate-id checks: they share this evaluate
+    // but never pass the reviewPayload option, so they must keep string data.
+    fixture.innerHTML = '<div id="target"></div><div id="target"></div>';
+    var node = fixture.querySelector('#target');
+    assert.isFalse(
+      axe.testUtils.getCheckEvaluate('duplicate-id').call(checkContext, node)
+    );
+    assert.isString(checkContext._data);
+    assert.equal(checkContext._data, 'target');
+    assert.isUndefined(checkContext._data.reviewPayload);
+  });
+
   it('should return remove duplicates', function () {
     assert.deepEqual(
       checks['duplicate-id'].after([
@@ -42,6 +55,19 @@ describe('duplicate-id', function () {
     );
   });
 
+  it('removes duplicates for object-shaped data (shared after with the aria variant)', function () {
+    // The shared after dedupes by data.id when data is an object
+    // ({ id, reviewPayload }), as emitted by the aria (bulk-review) variant.
+    assert.deepEqual(
+      checks['duplicate-id'].after([
+        { data: { id: 'a' } },
+        { data: { id: 'b' } },
+        { data: { id: 'b' } }
+      ]),
+      [{ data: { id: 'a' } }, { data: { id: 'b' } }]
+    );
+  });
+
   it('should ignore empty ids', function () {
     fixture.innerHTML =
       '<div data-testelm="1" id=""></div><div data-testelm="2"  id=""></div>';