Merge pull request #12 from browserstack/rem_logs

Remove unwanted logging

Author: vedharish

BrowserStackLocal.1.1.0.0.nupkg

@@ -32,10 +32,6 @@
     <PlatformTarget>AnyCPU</PlatformTarget>
   </PropertyGroup>
   <ItemGroup>
-    <Reference Include="log4net, Version=1.2.15.0, Culture=neutral, PublicKeyToken=669e0ddf0bb1aa2a, processorArchitecture=MSIL">
-      <HintPath>..\packages\log4net.2.0.5\lib\net20-full\log4net.dll</HintPath>
-      <Private>True</Private>
-    </Reference>
     <Reference Include="Newtonsoft.Json, Version=8.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
       <HintPath>..\packages\Newtonsoft.Json.8.0.3\lib\net20\Newtonsoft.Json.dll</HintPath>
       <Private>True</Private>
@@ -52,9 +48,7 @@
   <ItemGroup>
     <None Include="packages.config" />
   </ItemGroup>
-  <ItemGroup>
-    <Folder Include="log4net\" />
-  </ItemGroup>
+  <ItemGroup />
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

BrowserStackLocal.1.2.0.0.nupkg

@@ -1,14 +1,11 @@
 using System;
 using System.IO;
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.Text;
-using System.Text.RegularExpressions;
 using System.Net;
 
 using System.Security.AccessControl;
 using System.Security.Principal;
-using System.Threading;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 
@@ -78,14 +75,11 @@ public void downloadBinary()
 
       using (var client = new WebClient())
       {
-        Local.logger.Info("Downloading BrowserStackLocal..");
         client.DownloadFile(downloadURL, this.binaryAbsolute);
-        Local.logger.Info("Binary Downloaded.");
       }
 
       if (!File.Exists(binaryAbsolute))
       {
-        Local.logger.Error("Error accessing downloaded zip. Please check file permissions.");
         throw new Exception("Error accessing file " + binaryAbsolute);
       }
 
@@ -108,7 +102,6 @@ public virtual void Run(string accessKey, string folder, string logFilePath, str
       }
       if (!File.Exists(binaryAbsolute))
       {
-        Local.logger.Warn("BrowserStackLocal binary was not found at " + binaryAbsolute);
         downloadBinary();
       }
 
@@ -121,8 +114,6 @@ public virtual void Run(string accessKey, string folder, string logFilePath, str
       {
         File.WriteAllText(logFilePath, string.Empty);
       }
-      Local.logger.Info("BrowserStackLocal binary is located at " + binaryAbsolute);
-      Local.logger.Info("Starting Binary with arguments " + arguments.Replace(accessKey, "<access_key>"));
       RunProcess(arguments, processType); 
     }
 

BrowserStackLocal/BrowserStackLocal/BrowserStackLocal.csproj

@@ -1,9 +1,3 @@
-using log4net;
-using log4net.Appender;
-using log4net.Core;
-using log4net.Filter;
-using log4net.Layout;
-using log4net.Repository.Hierarchy;
 using System;
 using System.Collections.Generic;
 using System.IO;
@@ -13,15 +7,12 @@ namespace BrowserStack
 {
   public class Local
   {
-    private Hierarchy hierarchy;
     private string folder = "";
     private string accessKey = "";
     private string customLogPath = "";
     private string argumentString = "";
     private string customBinaryPath = "";
-    private PatternLayout patternLayout;
     protected BrowserStackTunnel tunnel = null;
-    public static ILog logger = LogManager.GetLogger("Local");
     private static KeyValuePair<string, string> emptyStringPair = new KeyValuePair<string, string>();
 
     private static List<KeyValuePair<string, string>> valueCommands = new List<KeyValuePair<string, string>>() {
@@ -40,7 +31,6 @@ public class Local
       new KeyValuePair<string, string>("forceproxy", "-forceproxy"),
       new KeyValuePair<string, string>("onlyAutomate", "-onlyAutomate"),
     };
-    private readonly string LOG4NET_CONFIG_FILE_PATH = Path.Combine(Directory.GetCurrentDirectory(), "log_config.xml");
 
     public bool isRunning()
     {
@@ -102,34 +92,9 @@ private void addArgs(string key, string value)
         }
       }
     }
-    private void setupLogging()
-    {
-      hierarchy = (Hierarchy)LogManager.GetRepository();
-
-      patternLayout = new PatternLayout();
-      patternLayout.ConversionPattern = "%date [%thread] %-5level %logger - %message%newline";
-      patternLayout.ActivateOptions();
-
-      ConsoleAppender consoleAppender = new ConsoleAppender();
-      consoleAppender.Threshold = Level.Info;
-      consoleAppender.Layout = patternLayout;
-      consoleAppender.ActivateOptions();
-
-      LoggerMatchFilter loggerMatchFilter = new LoggerMatchFilter();
-      loggerMatchFilter.LoggerToMatch = "Local";
-      loggerMatchFilter.AcceptOnMatch = true;
-      consoleAppender.AddFilter(loggerMatchFilter);
-      consoleAppender.AddFilter(new DenyAllFilter());
-
-      hierarchy.Root.AddAppender(consoleAppender);
-
-      hierarchy.Root.Level = Level.All;
-      hierarchy.Configured = true;
-    }
 
     public Local()
     {
-      setupLogging();
       tunnel = new BrowserStackTunnel();
     }
     public void start(List<KeyValuePair<string, string>> options)
@@ -166,7 +131,6 @@ public void start(List<KeyValuePair<string, string>> options)
           tunnel.Run(accessKey, folder, customLogPath, "start");
         } catch (Exception)
         {
-          logger.Warn("Running Local failed. Falling back to backup path.");
           except = true;
         }
         if (except)

BrowserStackLocal/BrowserStackLocal/BrowserStackTunnel.cs

@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.1.0.0")]
-[assembly: AssemblyFileVersion("1.1.0.0")]
+[assembly: AssemblyVersion("1.2.0.0")]
+[assembly: AssemblyFileVersion("1.2.0.0")]

BrowserStackLocal/BrowserStackLocal/Local.cs

@@ -1,5 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
-  <package id="log4net" version="2.0.5" targetFramework="net20" />
   <package id="Newtonsoft.Json" version="8.0.3" targetFramework="net20" />
 </packages>