custom args

Author: vedharish

BrowserStack/BrowserStack Unit Tests/LocalTests.cs

@@ -130,7 +130,7 @@ public void TestWorksWithBooleanOptions()
       local.setTunnel(tunnelMock.Object);
       local.start(options);
       tunnelMock.Verify(mock => mock.addBinaryPath(""), Times.Once);
-      tunnelMock.Verify(mock => mock.addBinaryArguments(It.IsRegex("-vvv.*-force.*-forcelocal*-forceproxy.*-onlyAutomate")), Times.Once());
+      tunnelMock.Verify(mock => mock.addBinaryArguments(It.IsRegex("-vvv.*-force.*-forcelocal.*-forceproxy.*-onlyAutomate")), Times.Once());
       tunnelMock.Verify(mock => mock.Run("dummyKey", "", logAbsolute), Times.Once());
       local.stop();
     }
@@ -160,6 +160,29 @@ public void TestWorksWithValueOptions()
       local.stop();
     }
 
+    [TestMethod]
+    public void TestWorksWithCustomOptions()
+    {
+      options = new List<KeyValuePair<string, string>>();
+      options.Add(new KeyValuePair<string, string>("key", "dummyKey"));
+      options.Add(new KeyValuePair<string, string>("customBoolKey1", "true"));
+      options.Add(new KeyValuePair<string, string>("customBoolKey2", "false"));
+      options.Add(new KeyValuePair<string, string>("customKey1", "customValue1"));
+      options.Add(new KeyValuePair<string, string>("customKey2", "customValue2"));
+      
+      local = new LocalClass();
+      Mock<BrowserStackTunnel> tunnelMock = new Mock<BrowserStackTunnel>();
+      tunnelMock.Setup(mock => mock.Run("dummyKey", "", logAbsolute));
+      local.setTunnel(tunnelMock.Object);
+      local.start(options);
+      tunnelMock.Verify(mock => mock.addBinaryPath(""), Times.Once);
+      tunnelMock.Verify(mock => mock.addBinaryArguments(
+        It.IsRegex("-customBoolKey1.*customBoolKey2.*-customKey1.*'customValue1'.*-customKey2.*'customValue2'")
+        ), Times.Once());
+      tunnelMock.Verify(mock => mock.Run("dummyKey", "", logAbsolute), Times.Once());
+      local.stop();
+    }
+
     [TestMethod]
     public void TestCallsFallbackOnFailure()
     {

BrowserStack/BrowserStack/Local.cs

@@ -68,13 +68,18 @@ private void addArgs(string key, string value)
       else if (key.Equals("logfile"))
       {
         customLogPath = value;
+      }
+      else if (key.Equals("verbose"))
+      {
+
       }
       else
       {
         result = valueCommands.Find(pair => pair.Key == key);
         if (!result.Equals(emptyStringPair))
         {
-          argumentString += result.Value + " " + value + " ";
+          argumentString += result.Value + " '" + value + "' ";
+          return;
         }
 
         result = booleanCommands.Find(pair => pair.Key == key);
@@ -83,8 +88,18 @@ private void addArgs(string key, string value)
           if (value.Trim().ToLower() == "true")
           {
             argumentString += result.Value + " ";
+            return;
           }
         }
+
+        if (value.Trim().ToLower() == "true")
+        {
+          argumentString += "-" + key + " ";
+        }
+        else
+        {
+          argumentString += "-" + key + " '" + value + "' ";
+        }
       }
     }
     private void setupLogging()